From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
To: Christoph Lameter <cl@linux-foundation.org>
Cc: "Koskinen Aaro (Nokia-D/Helsinki)" <aaro.koskinen@nokia.com>,
"mpm@selenic.com" <mpm@selenic.com>,
"penberg@cs.helsinki.fi" <penberg@cs.helsinki.fi>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [PATCH] SLUB: fix ARCH_KMALLOC_MINALIGN cases 64 and 256
Date: Thu, 27 Aug 2009 19:03:26 +0300 [thread overview]
Message-ID: <4A96AE4E.5000105@nokia.com> (raw)
In-Reply-To: <alpine.DEB.1.10.0908271151100.17470@gentwo.org>
On 08/27/2009 06:56 PM, ext Christoph Lameter wrote:
> On Thu, 27 Aug 2009, Aaro Koskinen wrote:
>
>> +++ b/include/linux/slub_def.h
>> @@ -154,8 +154,10 @@ static __always_inline int kmalloc_index(size_t size)
>> return KMALLOC_SHIFT_LOW;
>>
>> #if KMALLOC_MIN_SIZE<= 64
>> +#if KMALLOC_MIN_SIZE<= 32
>> if (size> 64&& size<= 96)
>> return 1;
>> +#endif
>
> Use elif here to move the condition together with the action?
Just a related question. KMALLOC_MIN_SIZE sounds confusing. If this is
about alignment, why not to call it KMALLOC_MIN_ALIGN instead?
--
Best Regards,
Artem Bityutskiy (D?N?N?N?D 1/4 D?D,N?N?N?DoD,D1)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-08-27 16:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-27 15:38 [PATCH] SLUB: fix ARCH_KMALLOC_MINALIGN cases 64 and 256 Aaro Koskinen
2009-08-27 15:56 ` Christoph Lameter
2009-08-27 16:03 ` Artem Bityutskiy [this message]
2009-08-27 16:23 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A96AE4E.5000105@nokia.com \
--to=artem.bityutskiy@nokia.com \
--cc=aaro.koskinen@nokia.com \
--cc=cl@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.