From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [Patch] cldcli: permit (much) longer messages Date: Thu, 27 Aug 2009 15:39:35 -0400 Message-ID: <4A96E0F7.6070909@garzik.org> References: <20090827122702.4f13193e@redhat.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20090827122702.4f13193e@redhat.com> Sender: hail-devel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: Pete Zaitcev Cc: Project Hail List On 08/27/2009 02:27 PM, Pete Zaitcev wrote: > A thought just occured to me that it's dumb to expand the message > itself when you can expand the format. This way all the potentially > long things like CLD pathnames do not count against your stack > and there's essentially no chance to get any messages truncated. > > The first snprintf is actually a strncat, but it's more concise. > > Signed-off-by: Pete Zaitcev applied