From: Mike Christie <michaelc@cs.wisc.edu>
To: Jayamohan Kalickal <jayamohank@serverengines.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH 4/6] RFC: beiscsi: iscsi hook in and handling code
Date: Fri, 28 Aug 2009 00:00:56 -0500 [thread overview]
Message-ID: <4A976488.3020708@cs.wisc.edu> (raw)
In-Reply-To: <20090827221905.bf8a1508@mailhost.serverengines.com>
Jayamohan Kalickal wrote:
> > +
> > + cls_session =
> > + iscsi_session_setup(&beiscsi_iscsi_transport, shost, cmds_max,
>
>
>
> Was there any limit on the number of commands per session? What about
> per port/scsi_host?
> The maximum number of commands is the queuedepth. Yes , we have a limit per port(scsi_host ) as well. Am I required to specify them here. I haven't understood the comment.
>
I was actually just asking because I was curious and because I was
wondering about what was going on below.
The host limit should just get set in scsi_host_template->can_queue (you
did this already). Then nelow you do not want to set the
shost->can_queue to cmds_max.
Did the queuedepth comment mean you have a per session limit too? If so
then you at least want to do a min(cmds_max, your_max_queue_depth) to
make sure the iscsi layer does not send more commands than you can handle.
next parent reply other threads:[~2009-08-28 5:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090827221905.bf8a1508@mailhost.serverengines.com>
2009-08-28 5:00 ` Mike Christie [this message]
2009-08-28 5:19 [PATCH 4/6] RFC: beiscsi: iscsi hook in and handling code Jayamohan Kalickal
-- strict thread matches above, loose matches on Subject: below --
2009-08-13 7:11 Jayamohan Kallickal
2009-08-15 23:22 ` Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A976488.3020708@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=jayamohank@serverengines.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.