From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tao Ma Date: Fri, 28 Aug 2009 15:41:47 +0800 Subject: [Ocfs2-devel] [PATCH] ocfs2: adds mlogs to aops.c -V3 In-Reply-To: <20090828073359.GC19658@mail.oracle.com> References: <200908140604.n7E64rhS031970@acsinet15.oracle.com> <20090828011018.GG18962@mail.oracle.com> <4A973D1D.70500@oracle.com> <20090828053911.GB19658@mail.oracle.com> <4A978098.60306@oracle.com> <20090828073359.GC19658@mail.oracle.com> Message-ID: <4A978A3B.6090408@oracle.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ocfs2-devel@oss.oracle.com Joel Becker wrote: > On Fri, Aug 28, 2009 at 03:00:40PM +0800, Wengang Wang wrote: >>>> and for the patch its self, I think the log contents are for developers >>>> to check(not for customer to view), so we can know what are printed by >>>> checking the src... so I am printing some parameters without pointing >>>> out what they are. >>> Yeah, I just don't know that we care :- >> Oh, excuse for my poor English :P, what do you mean here? >> you think it's OK that we don't point out what are printed? or you think >> we should point them out exactly in log contents? > > Sunil is right that developers will know what was printed and > that we don't need to be terribly detailed about that. I'm saying that > I don't know that entry/exit logs are useful. We never turn them on > because they are too noisy. agree. I never use entry/exit to debug something cause it produces noises much faster than the helpful info I really need. Regards, Tao