Re: [PATCH 13/13] wl1271: added Juuso Oikarinen as module author

[Luciano Coelho <luciano.coelho@nokia.com>]

ext Johannes Berg wrote:
> On Fri, 2009-08-28 at 00:00 +0300, Luciano Coelho wrote:
>   
>> Add Juuso as one of the module authors, since he's working heavily on this
>> module as well.
>>
>> Cc: Juuso Oikarinen <juuso.oikarinen@nokia.com>
>> Signed-off-by: Luciano Coelho <luciano.coelho@nokia.com>
>> ---
>>  drivers/net/wireless/wl12xx/wl1271_main.c |    3 ++-
>>  1 files changed, 2 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/net/wireless/wl12xx/wl1271_main.c b/drivers/net/wireless/wl12xx/wl1271_main.c
>> index a97d434..4163eac 100644
>> --- a/drivers/net/wireless/wl12xx/wl1271_main.c
>> +++ b/drivers/net/wireless/wl12xx/wl1271_main.c
>> @@ -1449,4 +1449,5 @@ module_init(wl1271_init);
>>  module_exit(wl1271_exit);
>>  
>>  MODULE_LICENSE("GPL");
>> -MODULE_AUTHOR("Luciano Coelho <luciano.coelho@nokia.com>");
>> +MODULE_AUTHOR("Luciano Coelho <luciano.coelho@nokia.com>, "
>> +	      "Juuso Oikarinen <juuso.oikarinen@nokia.com>");
>>     
>
> Use multiple MODULE_AUTHORs instead.
>   

Is that the right way to do it? At least in include/linux/module.h it 
says this:

/* Author, ideally of form NAME[, NAME]*[ and NAME] */
#define MODULE_AUTHOR(_author) MODULE_INFO(author, _author)

As I interpret it, it means that there should be one MODULE_AUTHOR with 
a string that contains all the names.  So actually the right way to do 
it would be this:

MODULE_AUTHOR("Luciano Coelho <luciano.coelho@nokia.com> and "
	      "Juuso Oikarinen <juuso.oikarinen@nokia.com>");


Or am I missing/misinterpreting something?

-- 
Cheers,
Luca.