From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Schroeder Subject: Re: pvops dom0 20090825 xen_acpi panic Date: Fri, 28 Aug 2009 14:15:35 +0200 Message-ID: <4A97CA67.1090908@dschroeder.info> References: <4A942449.8020707@dschroeder.info> <4D05DB80B95B23498C72C700BD6C2E0B339DB926@pdsmsx502.ccr.corp.intel.com> <4A96DE1C.8000003@dschroeder.info> <4D05DB80B95B23498C72C700BD6C2E0B339DBE9C@pdsmsx502.ccr.corp.intel.com> <4D05DB80B95B23498C72C700BD6C2E0B339DC003@pdsmsx502.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4D05DB80B95B23498C72C700BD6C2E0B339DC003@pdsmsx502.ccr.corp.intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Yu, Ke" Cc: Jeremy Fitzhardinge , "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org > I have tried 32bit case, however I cannot reproduce the kernel panic, either in 32bit dom0/32bit hypervisor case or 32bit dom0/64bit hypervisor case. if you still meet the kernel panic after applying the patch I posted, please let me know. I will dig it more. > i have tried the patch on bare metal (works) and under 32bit 3.4.2-rc1-pre (panic)...i dont get netconsole working, so i have no output...hope that helps... > Best Regards > Ke > >> -----Original Message----- >> From: xen-devel-bounces@lists.xensource.com >> [mailto:xen-devel-bounces@lists.xensource.com] On Behalf Of Yu, Ke >> Sent: Friday, August 28, 2009 11:06 AM >> To: Daniel Schroeder >> Cc: Jeremy Fitzhardinge; xen-devel@lists.xensource.com >> Subject: RE: [Xen-devel] pvops dom0 20090825 xen_acpi panic >> >> Oh I see. The following patch should fix the panic in bare metal, could you please >> have a try? For the 32bit, I am still trying to reproduce it, will make you updated >> later. >> >> Best Regards >> Ke >> >> =============== >> >> Fix xen_acpi_processor_extcntl_init xen_start_info NULL pointer issue >> >> when kernel runs in bare metal, the xen_start_info could be a NULL pointer, >> so add condition check to avoid the kernel panic. >> >> Signed-off-by: Yu Ke >> >> diff --git a/drivers/xen/acpi_processor.c b/drivers/xen/acpi_processor.c >> index d2b76e9..6a4e8e4 100644 >> --- a/drivers/xen/acpi_processor.c >> +++ b/drivers/xen/acpi_processor.c >> @@ -430,10 +430,14 @@ static int xen_hotplug_notifier(struct acpi_processor >> *pr, int event) >> >> static int __init xen_acpi_processor_extcntl_init(void) >> { >> - unsigned int pmbits = (xen_start_info->flags & SIF_PM_MASK) >> 8; >> + unsigned int pmbits; >> >> - if (!pmbits) >> + /* Only xen dom0 is allowed to handle ACPI processor info */ >> + if (!xen_initial_domain()) >> return 0; >> + >> + pmbits = (xen_start_info->flags & SIF_PM_MASK) >> 8; >> + >> if (pmbits & XEN_PROCESSOR_PM_CX) >> xen_ops.pm_ops[PM_TYPE_IDLE] = xen_cx_notifier; >> if (pmbits & XEN_PROCESSOR_PM_PX) >> >>> -----Original Message----- >>> From: Daniel Schroeder [mailto:sec@dschroeder.info] >>> Sent: Friday, August 28, 2009 3:27 AM >>> To: Yu, Ke >>> Cc: Jeremy Fitzhardinge; xen-devel@lists.xensource.com >>> Subject: Re: [Xen-devel] pvops dom0 20090825 xen_acpi panic >>> >>> Hi Ke, >>> >>>> Could you share more info on your configuration, so that I can reproduce it? >> E.g. >>> is it 32bit dom0 under 64bit hypervisor? Also do you mind attach the >>> domi0 .config file? >>> this is under a 32bit dom0 but it even happens on bare metal...under kvm >>> the same panic occurs... >>> .config is here http://x17.eu/xen_acpi_panic.config.gz >>> >>> - >>> daniel >