From: Oliver Hartkopp <socketcan@hartkopp.net>
To: "Gole, Anant" <anantgole@ti.com>
Cc: "socketcan-core@lists.berlios.de"
<socketcan-core@lists.berlios.de>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Wolfgang Grandegger <wg@grandegger.com>
Subject: Re: [PATCH] net-next:can: add TI CAN (HECC) driver
Date: Fri, 28 Aug 2009 15:27:49 +0200 [thread overview]
Message-ID: <4A97DB55.2000100@hartkopp.net> (raw)
In-Reply-To: <2A3DCF3DA181AD40BDE86A3150B27B6B02F6211049@dbde02.ent.ti.com>
Gole, Anant wrote:
>>> +#include <linux/can/platform/ti_hecc_platform.h>
>> Please use
>>
>> linux/can/platform/ti_hecc.c
>
> are you suggesting to keep the platform file name as ti_hecc.h?
>
Yep!
We currently have
linux/can/platform/sja1000.h
linux/can/platform/mcp251x.h
there. And as you need the full path for the include anyway, we decided to put
these CAN specific platform includes in linux/can/platform.
Else we would end with tons of <drivername>_platform.h in linux/can where we
have all the common stuff for CAN networking layer, etc.
Regards,
Oliver
next prev parent reply other threads:[~2009-08-28 13:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-28 11:18 [PATCH] net-next:can: add TI CAN (HECC) driver Anant Gole
2009-08-28 12:44 ` Oliver Hartkopp
2009-08-28 13:13 ` Gole, Anant
2009-08-28 13:27 ` Oliver Hartkopp [this message]
2009-09-01 9:04 ` Wolfram Sang
2009-09-01 9:32 ` Gole, Anant
[not found] <2A3DCF3DA181AD40BDE86A3150B27B6B02F621106B@dbde02.ent.ti.com>
2009-08-29 7:06 ` Wolfgang Grandegger
2009-08-31 7:22 ` Gole, Anant
2009-08-31 8:59 ` Wolfgang Grandegger
2009-08-31 10:29 ` Oliver Hartkopp
2009-08-31 10:43 ` Jan Kiszka
-- strict thread matches above, loose matches on Subject: below --
2009-10-05 10:02 Anant Gole
[not found] ` <1254736974-6685-1-git-send-email-anantgole-l0cyMroinI0@public.gmane.org>
2009-10-05 11:25 ` Wolfgang Grandegger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A97DB55.2000100@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=anantgole@ti.com \
--cc=netdev@vger.kernel.org \
--cc=socketcan-core@lists.berlios.de \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.