From: Mark Lord <liml@rtr.ca>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org, jens.axboe@oracle.com,
dwmw2@infradead.org
Subject: Re: [PATCH 6/7] block: allow large discard requests
Date: Sat, 29 Aug 2009 22:52:59 -0400 [thread overview]
Message-ID: <4A99E98B.403@rtr.ca> (raw)
In-Reply-To: <20090830025022.GE22870@parisc-linux.org>
Matthew Wilcox wrote:
> On Sat, Aug 29, 2009 at 10:49:02PM -0400, Mark Lord wrote:
>> Pardon my cursory review, but I don't see where this
>> patch set allows for more than a single extent/range
>> of sectors per TRIM command.
>
> It doesn't.
>
>> If it still does not group many extents into a single TRIM,
>> then it will be far to slow to be useful at all for SATA.
>
> That depends on the firmware. I do have plans to group the extents,
> but let's get something working before making it quick.
..
In this situation, it's more a case of making it *not sucky slow*
than getting to the point where we think about making it "quick".
One extent at a time is glacial.
Cheers
next prev parent reply other threads:[~2009-08-30 2:52 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-29 23:03 [PATCH 0/7] discard support revisited Christoph Hellwig
2009-08-29 23:03 ` [PATCH 1/7] Make DISCARD_BARRIER and DISCARD_NOBARRIER writes instead of reads Christoph Hellwig
2009-09-03 17:52 ` David Woodhouse
2009-09-03 17:56 ` Matthew Wilcox
2009-08-29 23:03 ` [PATCH 2/7] block: use blkdev_issue_discard in blk_ioctl_discard Christoph Hellwig
2009-09-01 9:06 ` Steven Whitehouse
2009-09-11 22:26 ` Christoph Hellwig
2009-09-14 9:40 ` Jens Axboe
2009-08-29 23:03 ` [PATCH 3/7] block: discard may need to allocate pages Christoph Hellwig
2009-08-29 23:03 ` [PATCH 4/7] sd: add support for WRITE SAME (16) with unmap bit Christoph Hellwig
2009-08-30 0:43 ` Douglas Gilbert
2009-08-30 1:05 ` Christoph Hellwig
2009-08-30 2:43 ` Douglas Gilbert
2009-08-30 2:48 ` Christoph Hellwig
2009-08-30 11:12 ` Sergei Shtylyov
2009-08-30 17:14 ` Christoph Hellwig
2009-08-29 23:03 ` [PATCH 5/7] libata: Add support for TRIM Christoph Hellwig
2009-08-29 23:03 ` [PATCH 6/7] block: allow large discard requests Christoph Hellwig
2009-08-30 2:49 ` Mark Lord
2009-08-30 2:50 ` Matthew Wilcox
2009-08-30 2:52 ` Mark Lord [this message]
2009-08-30 2:56 ` Christoph Hellwig
2009-08-29 23:03 ` [PATCH 7/7] xfs: add batches discard support Christoph Hellwig
2009-08-29 23:37 ` [PATCH 0/7] discard support revisited Matthew Wilcox
2009-08-30 2:15 ` Christoph Hellwig
2009-08-30 3:03 ` Matthew Wilcox
2009-08-30 20:17 ` James Bottomley
2009-08-30 21:42 ` Matthew Wilcox
2009-08-30 22:48 ` Christoph Hellwig
2009-09-02 19:46 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A99E98B.403@rtr.ca \
--to=liml@rtr.ca \
--cc=dwmw2@infradead.org \
--cc=hch@infradead.org \
--cc=jens.axboe@oracle.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.