From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Kent Subject: Re: autofs does not umount Date: Mon, 31 Aug 2009 11:37:16 +0800 Message-ID: <4A9B456C.2070607@themaw.net> References: <20090827222825.GA23043@merfinllc.com> <20090827232753.GA26300@merfinllc.com> <4A971D47.3050503@themaw.net> <20090828001545.GA28811@merfinllc.com> <4A976E14.7000301@themaw.net> <20090828164358.GA6935@merfinllc.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20090828164358.GA6935@merfinllc.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: autofs-bounces@linux.kernel.org Errors-To: autofs-bounces@linux.kernel.org To: Al Viro Cc: autofs mailing list , Aaron Straus Aaron Straus wrote: > Hi, > > On Aug 28 01:41 PM, Ian Kent wrote: >>> - if (!may_umount_tree(mnt)) { >>> + if (!may_umount_tree(&path.mnt)) { >> My bad, sorry. >> I think that really should be path.mnt not &path.mnt. > > Yep. I confirm the fixed-up patch fixes the problems I'm seeing. Al, Would you like me to post my corrected patch to LKML (to akpm or ??) or would you like to take care of it? Ian