All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Simon Horman <horms@verge.net.au>
Cc: lvs-devel@vger.kernel.org, netdev@vger.kernel.org,
	David Miller <davem@davemloft.net>,
	Julius Volz <julius.volz@gmail.com>,
	Rob Gallagher <robert.gallagher@heanet.ie>
Subject: Re: [patch, v2] IPVS: Add handling of incoming ICMPV6 messages
Date: Mon, 31 Aug 2009 16:23:38 +0200	[thread overview]
Message-ID: <4A9BDCEA.1090008@trash.net> (raw)
In-Reply-To: <20090831075904.GA3430@verge.net.au>

Simon Horman wrote:
> From: Julius Volz <julius.volz@gmail.com>
> 
> IPVS: Add handling of incoming ICMPV6 messages
> 
> Add handling of incoming ICMPv6 messages.
> This follows the handling of IPv4 ICMP messages.
> 
> Amongst ther things this problem allows IPVS to behave sensibly
> when an ICMPV6_PKT_TOOBIG message is received:
> 
>     This message is received when a realserver sends a packet >PMTU to the
>     client. The hop on this path with insufficient MTU will generate an
>     ICMPv6 Packet Too Big message back to the VIP. The LVS server receives
>     this message, but the call to the function handling this has been
>     missing. Thus, IPVS fails to forward the message to the real server,
>     which then does not adjust the path MTU. This patch adds the missing
>     call to ip_vs_in_icmp_v6() in ip_vs_in() to handle this situation.
> 
>     Thanks to Rob Gallagher from HEAnet for reporting this issue and for
>     testing this patch in production (with direct routing mode).

Applied, thanks.

      reply	other threads:[~2009-08-31 14:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-31  7:59 [patch, v2] IPVS: Add handling of incoming ICMPV6 messages Simon Horman
2009-08-31 14:23 ` Patrick McHardy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A9BDCEA.1090008@trash.net \
    --to=kaber@trash.net \
    --cc=davem@davemloft.net \
    --cc=horms@verge.net.au \
    --cc=julius.volz@gmail.com \
    --cc=lvs-devel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=robert.gallagher@heanet.ie \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.