From: Joerg Albert <jal2@gmx.de>
To: Chunkeey@web.de
Cc: "John W. Linville" <linville@tuxdriver.com>,
Johannes Berg <johannes@sipsolutions.net>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] ar9170: added phy register initialisation from eeprom values
Date: Mon, 31 Aug 2009 21:34:06 +0200 [thread overview]
Message-ID: <4A9C25AE.9020109@gmx.de> (raw)
In-Reply-To: <1789900589@web.de>
On 08/31/2009 11:53 AM, Chunkeey@web.de wrote:
> ...
> See Documentation/CodingStyle - Chapter 8
>
> The preferred style for long (multi-line) comments is:
> /*
> * look up a certain register in ar5416_phy_init[] and return the init. value
> * for the band and bandwidth given. Return 0 if register address not found.
> */
> ...
Thanks for the comments. I agree with all of them and will re-spin a patch.
> It's amazing how much **** you can _cut_ from the vendor driver.
Yes, at first sight it looks really complex but it isn't.
> BTW: does this patch help the 1-stage fw stability, or is it still broken?
Turned out I had a corrupt firmware file. After downloading from Luis' URL it works fine
with my WNDA3100. Guess I had an earlier version from before 2009/05/28 or firefox corrupted it during download.
What's your setup to get 80+ MBit/s throughput with the two-stage firmware?
I've used an 802.11g AP so far, but have access to an 802.11n dual-band AP now.
Guess I should use 5GHz as 2.4 is rather crowded here.
How can I put ar9170 into 802.11n/40MHz mode?
Regards,
Jörg.
next prev parent reply other threads:[~2009-08-31 19:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-31 9:53 [PATCH] ar9170: added phy register initialisation from eeprom values Chunkeey
2009-08-31 19:34 ` Joerg Albert [this message]
2009-08-31 21:37 ` Christian Lamparter
2009-09-02 23:02 ` [PATCH v2] " Joerg Albert
2009-09-03 18:56 ` Christian Lamparter
[not found] ` <4A9EF532.8070500@gmx.de>
2009-09-03 16:16 ` [PATCH] " Christian Lamparter
-- strict thread matches above, loose matches on Subject: below --
2009-08-30 23:15 Joerg Albert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A9C25AE.9020109@gmx.de \
--to=jal2@gmx.de \
--cc=Chunkeey@web.de \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.