From: Jiri Slaby <jirislaby@gmail.com>
To: James Morris <jmorris@namei.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
mingo@redhat.com, oleg@redhat.com, linux-kernel@vger.kernel.org,
Stephen Smalley <sds@tycho.nsa.gov>,
Eric Paris <eparis@parisplace.org>,
David Howells <dhowells@redhat.com>,
linux-security-module@vger.kernel.org,
Frank Mayhar <fmayhar@google.com>
Subject: Re: [PATCH 1/6] SECURITY: selinux, fix update_rlimit_cpu parameter
Date: Tue, 01 Sep 2009 08:20:18 +0200 [thread overview]
Message-ID: <4A9CBD22.1050401@gmail.com> (raw)
In-Reply-To: <alpine.LRH.2.00.0909010811320.22374@tundra.namei.org>
On 09/01/2009 12:22 AM, James Morris wrote:
> On Mon, 31 Aug 2009, Jiri Slaby wrote:
>
> [added lsm list]
>
>> diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
>> index cf41988..496e626 100644
>> --- a/security/selinux/hooks.c
>> +++ b/security/selinux/hooks.c
>> @@ -2360,7 +2360,7 @@ static void selinux_bprm_committing_creds(struct linux_binprm *bprm)
>> initrlim = init_task.signal->rlim + i;
>> rlim->rlim_cur = min(rlim->rlim_max, initrlim->rlim_cur);
>> }
>> - update_rlimit_cpu(rlim->rlim_cur);
>> + update_rlimit_cpu(current->signal->rlim[RLIMIT_CPU].rlim_cur);
>
> This doesn't look correct to me: the original code determines
> rlim->rlim_cur and then updates current to that. With your change, this
> value is not used.
No, the for loop is to alter all limits according to the init limits.
update_rlimit_cpu is called for RLIMIT_CPU to annotate scheduler about
CPU time changes (if any).
BTW this was introduced by f06febc96ba8e0af80bcc3eaec0a109e88275fac
(timers: fix itimer/many thread hang).
next prev parent reply other threads:[~2009-09-01 6:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-31 18:56 [PATCH 1/6] SECURITY: selinux, fix update_rlimit_cpu parameter Jiri Slaby
2009-08-31 18:56 ` [PATCH 2/6] SECURITY: add task_struct to setrlimit Jiri Slaby
2009-08-31 19:07 ` Eric Paris
2009-09-01 8:51 ` James Morris
2009-08-31 18:56 ` [PATCH 3/6] core: add task_struct to update_rlimit_cpu Jiri Slaby
2009-09-01 8:51 ` James Morris
2009-08-31 18:56 ` [PATCH 4/6] core: split sys_setrlimit Jiri Slaby
2009-08-31 18:56 ` [PATCH 5/6] core: allow setrlimit to non-current tasks Jiri Slaby
2009-09-01 16:22 ` Oleg Nesterov
2009-08-31 18:56 ` [PATCH 6/6] FS: proc, make limits writable Jiri Slaby
2009-08-31 22:22 ` [PATCH 1/6] SECURITY: selinux, fix update_rlimit_cpu parameter James Morris
2009-09-01 6:20 ` Jiri Slaby [this message]
2009-09-01 8:48 ` James Morris
2009-09-01 8:50 ` James Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A9CBD22.1050401@gmail.com \
--to=jirislaby@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=eparis@parisplace.org \
--cc=fmayhar@google.com \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=oleg@redhat.com \
--cc=sds@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.