All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org>
To: xenomai@xenomai.org, xenomai@xenomai.org
Subject: Re: [Xenomai-core] Xenomai v2.4.9.1
Date: Tue, 01 Sep 2009 11:16:03 +0200	[thread overview]
Message-ID: <4A9CE653.6060508@domain.hid> (raw)
In-Reply-To: <1251794938.3205.20.camel@domain.hid>

Philippe Gerum wrote:
> We had a couple of brown paper bag issues in v2.4.9, particularly in the
> interrupt pipeline for the ARM port, but also a time conversion bug
> which basically affects any architecture with high frequency CPUs
> (x86-ers, this one is for you).

A note for users of Xenomai on the ARM architecture.

A newly added check in Xenomai 2.4.9 allowed us to find a bug in the 
I-pipe patch for ARM, which is actually there since the 
adeos-ipipe-2.6.19-arm-1.7-00 patch. If you are using the 2.4 branch, 
please upgrade to the 2.4.9.1 release.

If you are using an earlier branch, the only thing we can suggest is a 
patch which you should apply to the I-pipe patched kernel:

diff --git a/arch/arm/include/asm/system.h b/arch/arm/include/asm/system.h
index e2b0c3c..e77a017 100644
--- a/arch/arm/include/asm/system.h
+++ b/arch/arm/include/asm/system.h
@@ -217,7 +217,8 @@ extern struct task_struct *__switch_to(struct task_struct *,
 do {									\
	local_irq_disable_hw_cond();					\
	last = __switch_to(prev,task_thread_info(prev), task_thread_info(next));
-	local_irq_enable_hw_cond();					\
+	if (ipipe_root_domain_p) \
+		local_irq_enable_hw_cond(); \
 } while (0)

 #if defined(CONFIG_CPU_SA1100) || defined(CONFIG_CPU_SA110)

Or, for older kernels:

diff --git a/include/asm-arm/system.h b/include/asm-arm/system.h
index e2b0c3c..e77a017 100644
--- a/include/asm-arm/system.h
+++ b/include/asm-arm/system.h
@@ -217,7 +217,8 @@ extern struct task_struct *__switch_to(struct task_struct *,
 do {									\
	local_irq_disable_hw_cond();					\
	last = __switch_to(prev,task_thread_info(prev), task_thread_info(next));
-	local_irq_enable_hw_cond();					\
+	if (ipipe_root_domain_p) \
+		local_irq_enable_hw_cond(); \
 } while (0)

 #if defined(CONFIG_CPU_SA1100) || defined(CONFIG_CPU_SA110)


-- 
                                          Gilles



      reply	other threads:[~2009-09-01  9:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-01  8:48 [Xenomai-core] Xenomai v2.4.9.1 Philippe Gerum
2009-09-01  9:16 ` Gilles Chanteperdrix [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A9CE653.6060508@domain.hid \
    --to=gilles.chanteperdrix@xenomai.org \
    --cc=xenomai@xenomai.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.