From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH] KVM: Use thread debug register storage instead of kvm specific data Date: Tue, 01 Sep 2009 13:45:00 +0200 Message-ID: <4A9D093C.90508@siemens.com> References: <1251798248-13164-1-git-send-email-avi@redhat.com> <20090901112220.GA18271@amt.cnet> <4A9D056E.4030906@siemens.com> <4A9D0678.5040800@siemens.com> <4A9D08C7.2070206@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , "kvm@vger.kernel.org" To: Avi Kivity Return-path: Received: from david.siemens.de ([192.35.17.14]:21357 "EHLO david.siemens.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754082AbZIALpN (ORCPT ); Tue, 1 Sep 2009 07:45:13 -0400 In-Reply-To: <4A9D08C7.2070206@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Avi Kivity wrote: > On 09/01/2009 02:33 PM, Jan Kiszka wrote: >> For the time being, falling back to conservative save/restore if kgdb is >> configured in and kgdb_connected != 0 should allow us to apply this >> optimization otherwise. >> > > I prefer a real fix instead of spaghettiing the code this way (and in > the meanwhile I'm fine with kgdb hardware breakpoints not working while > kvm is running). Then file a patch that makes CONFIG_KVM depend on !CONFIG_KGDB (or vice versa). Silent breakages are evil. Jan -- Siemens AG, Corporate Technology, CT SE 2 Corporate Competence Center Embedded Linux