From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: Use thread debug register storage instead of kvm specific data Date: Tue, 01 Sep 2009 15:02:33 +0300 Message-ID: <4A9D0D59.9020406@redhat.com> References: <1251798248-13164-1-git-send-email-avi@redhat.com> <20090901112220.GA18271@amt.cnet> <4A9D056E.4030906@siemens.com> <4A9D0678.5040800@siemens.com> <4A9D08C7.2070206@redhat.com> <4A9D093C.90508@siemens.com> <4A9D0BF0.4000400@redhat.com> <4A9D0D19.6000106@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , "kvm@vger.kernel.org" To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:10510 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753721AbZIAMCf (ORCPT ); Tue, 1 Sep 2009 08:02:35 -0400 In-Reply-To: <4A9D0D19.6000106@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: On 09/01/2009 03:01 PM, Jan Kiszka wrote: > Avi Kivity wrote: > >> On 09/01/2009 02:45 PM, Jan Kiszka wrote: >> >>> Avi Kivity wrote: >>> >>> >>>> On 09/01/2009 02:33 PM, Jan Kiszka wrote: >>>> >>>> >>>>> For the time being, falling back to conservative save/restore if kgdb is >>>>> configured in and kgdb_connected != 0 should allow us to apply this >>>>> optimization otherwise. >>>>> >>>>> >>>>> >>>> I prefer a real fix instead of spaghettiing the code this way (and in >>>> the meanwhile I'm fine with kgdb hardware breakpoints not working while >>>> kvm is running). >>>> >>>> >>> Then file a patch that makes CONFIG_KVM depend on !CONFIG_KGDB (or vice >>> versa). Silent breakages are evil. >>> >>> >> Distros typically enable both. >> > Then we need to resolve it right from the start, not in some distant > future. We already have everything we need available, we could just try > to refactor it to a nicer interface (something that encapsulates both > compile and runtime tests). > I'll look at doing something. It shouldn't be difficult. -- error compiling committee.c: too many arguments to function