From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: Use thread debug register storage instead of kvm specific data Date: Tue, 01 Sep 2009 16:39:58 +0300 Message-ID: <4A9D242E.40507@redhat.com> References: <1251798248-13164-1-git-send-email-avi@redhat.com> <4A9CFA90.50202@siemens.com> <4A9D0289.7080201@redhat.com> <4A9D223E.5030906@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , "kvm@vger.kernel.org" To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:42820 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754437AbZIANkB (ORCPT ); Tue, 1 Sep 2009 09:40:01 -0400 In-Reply-To: <4A9D223E.5030906@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: On 09/01/2009 04:31 PM, Jan Kiszka wrote: >> The hardware will clear dr7 on exit. >> > Given this fact, I wonder why you want to reload host dr0..3 on > vcpu->arch.switch_db_regs. if (unlikely(test_thread_flag(TIF_DEBUG))) > should suffice then, right? > I think you're right. It would mean unsynced hardware and software registers, but only if debugging is disabled, which should be fine. -- error compiling committee.c: too many arguments to function