From: Avi Kivity <avi@redhat.com>
To: Mohammed Gamal <m.gamal005@gmail.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, kvm@vger.kernel.org
Subject: Re: [PATCHv3] VMX: Enhance invalid guest state emulation
Date: Tue, 01 Sep 2009 19:23:26 +0300 [thread overview]
Message-ID: <4A9D4A7E.5000800@redhat.com> (raw)
In-Reply-To: <52d4a3890909010632wd1b6d9fxb2b5f5042e151b4f@mail.gmail.com>
On 09/01/2009 04:32 PM, Mohammed Gamal wrote:
>>> I'd appreciate any suggestions you have to alleviate this.
>>>
>> I fail to see why you need an internal loop if you can use the external
>> (__vcpu_run) one.
>>
> Because it's not just used by VMX. So I don't think it'd be wise to
> use it for something that's VMX-specific.
>
The loop is there anyway. The only question is whether
vmx_handle_exit() emulates on instruction or many.
Emulating one instruction is slower, but will get interrupt injection
more accurate (once we have emulated real mode interrupt injection).
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2009-09-01 16:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-01 10:48 [PATCHv3] VMX: Enhance invalid guest state emulation Mohammed Gamal
2009-09-01 11:48 ` Marcelo Tosatti
2009-09-01 12:14 ` Mohammed Gamal
2009-09-01 12:18 ` Marcelo Tosatti
2009-09-01 13:08 ` Mohammed Gamal
2009-09-01 13:29 ` Marcelo Tosatti
2009-09-01 13:32 ` Mohammed Gamal
2009-09-01 15:55 ` Marcelo Tosatti
2009-09-01 16:23 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A9D4A7E.5000800@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=m.gamal005@gmail.com \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.