From mboxrd@z Thu Jan 1 00:00:00 1970 From: Troy Kisky Subject: Re: [PATCH 1/3] ASoC: DaVinci: i2s, reduce underruns by combining into 1 element Date: Tue, 01 Sep 2009 11:23:27 -0700 Message-ID: <4A9D669F.6090906@boundarydevices.com> References: <1251761505-11353-1-git-send-email-troy.kisky@boundarydevices.com> <20090901105302.GD18651@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from smtpauth01.csee.onr.siteprotect.com (smtpauth01.csee.onr.siteprotect.com [64.26.60.145]) by alsa0.perex.cz (Postfix) with ESMTP id 8726024150 for ; Tue, 1 Sep 2009 20:23:36 +0200 (CEST) In-Reply-To: <20090901105302.GD18651@sirena.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: avm@ti.com, davinci-linux-open-source@linux.davincidsp.com, alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org Mark Brown wrote: > On Mon, Aug 31, 2009 at 04:31:43PM -0700, Troy Kisky wrote: > >> + /* >> + * Allowing this is more efficient and eliminates left and right swaps >> + * caused by underruns, but will swap the left and right channels >> + * when compared to previous behavior. >> + */ >> + unsigned disable_channel_combine:1; > > Last time you submitted this I suggested changing this to make the > default the other way round so that there's no breakage on existing > boards which aren't designed for this channel swap behaviour. Is there > some reason not to do that? > I think that it is better to make sure that they know the possible problems disabling this may cause. Channels always swapped seems a lot better than channels randomly swapped. Troy