From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] MTD:NAND: ADD new ECC mode NAND_ECC_HW_OOB_FIRST
Date: Tue, 01 Sep 2009 15:06:11 -0500 [thread overview]
Message-ID: <4A9D7EB3.9090100@freescale.com> (raw)
In-Reply-To: <200909011359.52037.mwaddel@control4.com>
Matt Waddel wrote:
> Hi Scott and Sandeep,
>
> As long as we're looking at these patches again I had a question about
> patch 1 of 2 in this series.
>
> The following part of the patch added a definition for:
>
> chip->ecc.read_page = nand_read_page_hwecc_oob_first
>
> but since there aren't any "break" statements until "case NAND_ECC_SOFT:"
> it looks like the chip->ecc.read_page definition ends up being set to:
>
> chip->ecc.read_page = nand_read_page_swecc.
>
> Maybe this is explains why things seem to be working???
No, that's OK -- it stops before that on the
"if (mtd->writesize >= chip->ecc.size) break;" line (or if that
condition is not true, it prints a warning that it is falling back on
soft ecc).
-Scott
next prev parent reply other threads:[~2009-09-01 20:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <7081825318460577925@unknownmsgid>
2009-09-01 15:22 ` [U-Boot] [PATCH 2/2] MTD:NAND: ADD new ECC mode NAND_ECC_HW_OOB_FIRST John Rigby
2009-09-01 15:36 ` Scott Wood
2009-09-01 16:03 ` Paulraj, Sandeep
2009-09-01 16:31 ` John Rigby
[not found] ` <0554BEF07D437848AF01B9C9B5F0BC5D9217B3B7@dlee01.ent.ti.com>
2009-09-01 16:55 ` John Rigby
2009-09-01 19:19 ` Scott Wood
2009-09-01 19:59 ` Matt Waddel
2009-09-01 20:06 ` Scott Wood [this message]
2009-08-18 16:00 Scott Wood
-- strict thread matches above, loose matches on Subject: below --
2009-08-11 22:34 Scott Wood
2009-08-12 11:48 ` Paulraj, Sandeep
2009-08-12 16:11 ` Scott Wood
[not found] ` <0554BEF07D437848AF01B9C9B5F0BC5D7C628A5C@dlee01.ent.ti.com>
2009-08-12 17:11 ` Scott Wood
2009-08-14 14:03 ` Paulraj, Sandeep
2009-08-11 22:17 Scott Wood
2009-08-10 17:27 s-paulraj at dal.design.ti.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A9D7EB3.9090100@freescale.com \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.