From: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
To: David Miller <davem@davemloft.net>
Cc: rostedt@goodmis.org, mingo@elte.hu, nhorman@tuxdriver.com,
fweisbec@gmail.com, yjwei@cn.fujitsu.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH resend] tracing/events: convert NAPI's tracepoint via TRACE_EVENT
Date: Wed, 02 Sep 2009 11:12:19 +0800 [thread overview]
Message-ID: <4A9DE293.6050703@cn.fujitsu.com> (raw)
In-Reply-To: <20090901.182645.153420711.davem@davemloft.net>
David Miller wrote:
> This patch can't be split up, so I'm wondering how you suggest to
> handle this patch given that you have declared that define_trace.h
> changes aren't to go through the subsystem tree?
>
> If we do the define_trace.h change only, we break the build
> (lack of macro defined for the trace).
>
> If we do only the other parts of his patch, we get a duplicate
> definition.
>
This patch cooperate with my previous patch to solve the include file
dependencies problem. So, we do better put those two patches together.
(both in -tip tree or/add both in network tree)
The previous patch is below:
Commit-ID: 5ac35daa9343936038a3c9c4f4d6d3fe6a2a7bd8
Gitweb: http://git.kernel.org/tip/5ac35daa9343936038a3c9c4f4d6d3fe6a2a7bd8
Author: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
AuthorDate: Tue, 25 Aug 2009 14:06:22 +0800
Committer: Steven Rostedt <rostedt@goodmis.org>
CommitDate: Wed, 26 Aug 2009 00:32:09 -0400
tracing/events: fix the include file dependencies
> And keep in mind that Neil and Xiao are probably going to want to do
> work on top of this to the networking bits. Thus if we put this patch
> here into the tracing tree, I'll have to develop a dependency on the
> tracing tree and I think that will go over like a fart in a spacesuit
> with the -next crowd and Stephen Rothwell in particular.
>
Thank you, David
Xiao
next prev parent reply other threads:[~2009-09-02 3:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-31 6:16 [PATCH resend] tracing/events: convert NAPI's tracepoint via TRACE_EVENT Xiao Guangrong
2009-08-31 8:49 ` Ingo Molnar
2009-08-31 18:09 ` Steven Rostedt
2009-09-02 1:26 ` David Miller
2009-09-02 3:12 ` Xiao Guangrong [this message]
2009-09-04 7:06 ` Ingo Molnar
2009-08-31 18:03 ` Steven Rostedt
2009-09-01 1:06 ` Xiao Guangrong
2009-09-01 1:41 ` Steven Rostedt
2009-09-01 11:04 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A9DE293.6050703@cn.fujitsu.com \
--to=xiaoguangrong@cn.fujitsu.com \
--cc=davem@davemloft.net \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=rostedt@goodmis.org \
--cc=yjwei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.