All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wei Yongjun <yjwei@cn.fujitsu.com>
To: linux-sctp@vger.kernel.org
Subject: [PATCH 2/2] sctp: remove no used member from struct sctp_packet
Date: Wed, 02 Sep 2009 05:09:36 +0000	[thread overview]
Message-ID: <4A9DFE10.4060600@cn.fujitsu.com> (raw)

member has_auth of struct sctp_packet is defined and
set, but not used. struct sctp_packet has auth member
can indicate the packet contains an AUTH chunk. So
this patch remove it.

Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
---
 include/net/sctp/structs.h |    3 ---
 net/sctp/output.c          |    5 -----
 2 files changed, 0 insertions(+), 8 deletions(-)

diff --git a/include/net/sctp/structs.h b/include/net/sctp/structs.h
index edfcacf..9996097 100644
--- a/include/net/sctp/structs.h
+++ b/include/net/sctp/structs.h
@@ -817,9 +817,6 @@ struct sctp_packet {
 	/* This packet contains a SACK chunk. */
 	__u8 has_sack;
 
-	/* This packet contains an AUTH chunk */
-	__u8 has_auth;
-
 	/* This packet contains at least 1 DATA chunk */
 	__u8 has_data;
 
diff --git a/net/sctp/output.c b/net/sctp/output.c
index fbbfbce..c115e8b 100644
--- a/net/sctp/output.c
+++ b/net/sctp/output.c
@@ -78,7 +78,6 @@ struct sctp_packet *sctp_packet_config(struct sctp_packet *packet,
 	packet->vtag = vtag;
 	packet->has_cookie_echo = 0;
 	packet->has_sack = 0;
-	packet->has_auth = 0;
 	packet->has_data = 0;
 	packet->ipfragok = 0;
 	packet->auth = NULL;
@@ -123,7 +122,6 @@ struct sctp_packet *sctp_packet_init(struct sctp_packet *packet,
 	packet->vtag = 0;
 	packet->has_cookie_echo = 0;
 	packet->has_sack = 0;
-	packet->has_auth = 0;
 	packet->has_data = 0;
 	packet->ipfragok = 0;
 	packet->malloced = 0;
@@ -325,8 +323,6 @@ append:
 			goto finish;
 		/* Disallow SACK bundling after DATA. */
 		packet->has_sack = 1;
-		/* Disallow AUTH bundling after DATA */
-		packet->has_auth = 1;
 		/* Let it be knows that packet has DATA in it */
 		packet->has_data = 1;
 		/* timestamp the chunk for rtx purposes */
@@ -341,7 +337,6 @@ append:
 		break;
 
 	    case SCTP_CID_AUTH:
-		packet->has_auth = 1;
 		packet->auth = chunk;
 		break;
 	}
-- 
1.6.2.2





             reply	other threads:[~2009-09-02  5:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-02  5:09 Wei Yongjun [this message]
2009-09-02 15:36 ` [PATCH 2/2] sctp: remove no used member from struct sctp_packet Vlad Yasevich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A9DFE10.4060600@cn.fujitsu.com \
    --to=yjwei@cn.fujitsu.com \
    --cc=linux-sctp@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.