All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@cam.ac.uk>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] Ambient Light sensor for Intersil-ISL29020 device
Date: Wed, 02 Sep 2009 15:26:08 +0000	[thread overview]
Message-ID: <4A9E8E90.8090208@cam.ac.uk> (raw)
In-Reply-To: <20090811185416.GB32002@intel.com>

Jean Delvare wrote:
> On Thu, 13 Aug 2009 16:22:29 +0530, Trisal, Kalhan wrote:
>> This driver used Hwmon interface ,
> 
> No, it doesn't. It registers as a hwmon device but it doesn't implement
> _any_ feature listed in Documentation/hwmon/sysfs-interface. Which can
> be easily explained: your device is not a hardware monitoring device.
> 
>> I don't find the ils29003 registering with hwmon. I still believe
>> this should be part of hwmon group.
> 
> No, it shouldn't. hwmon is for hardware monitoring. Other sensor types
> must find a different home.
For info current options I know of:

1) drivers/misc (where the isl290003 is, previously intention was to possibly
move this to iio when / if that gets merged)

2) drivers/staging/iio/light (tsl2561) I'm happy with more light sensors
in there, though the interface might need some hammering out.  Currently none
of them are using any iio specific features so can certainly go elsewhere
if people would prefer. In my personal view a lot of the processing currently
in the various drivers ought not to be in the kernel, but that's a different
matter)  IIO is currently in Greg KH's tree.

3) drivers/als (acpi ambient light sensor - latest version posted to lkml a couple
of days ago - now in acpi-testing I think)  This one is a bit different, but perhaps
a conversation needs to be opened with them to see if the requirements overlap
sufficiently to use a shared framework.) I've copied in those most active in the
discussion on that. (sorry all if you aren't interested!)

Places that aren't an option.

drivers/i2c/chips as thats going aways shortly. tsl2550 driver will have to
move out of there.
Hwmon for the reasons Jean just stated.

Any others out there?

Worth starting a more detailed discussion on a unified framework / location
for these sort of sensors?  (lkml probably)

Cheers,

Jonathan





_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  parent reply	other threads:[~2009-09-02 15:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-11  8:13 [lm-sensors] Ambient Light sensor for Intersil-ISL29020 device Kalhan Trisal
2009-08-11 13:29 ` Cory T. Tusar
2009-08-13 10:56 ` Trisal, Kalhan
2009-09-02 12:51 ` Jean Delvare
2009-09-02 15:26 ` Jonathan Cameron [this message]
2009-09-02 20:07 ` Pavel Machek
2009-09-03  3:35 ` Zhang Rui
2009-09-03 10:51 ` Jean Delvare
2009-09-03 12:50 ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A9E8E90.8090208@cam.ac.uk \
    --to=jic23@cam.ac.uk \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.