From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH 2/6] Nested VMX patch 2 implements vmclear
Date: Wed, 02 Sep 2009 22:38:22 +0300
Message-ID: <4A9EC9AE.8080807@redhat.com>
References: <1251905916-2834-1-git-send-email-oritw@il.ibm.com> <1251905916-2834-2-git-send-email-oritw@il.ibm.com> <1251905916-2834-3-git-send-email-oritw@il.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org, benami@il.ibm.com, muli@il.ibm.com,
	abelg@il.ibm.com, aliguori@us.ibm.com, mmday@us.ibm.com
To: oritw@il.ibm.com
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:37545 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751528AbZIBTh6 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 2 Sep 2009 15:37:58 -0400
In-Reply-To: <1251905916-2834-3-git-send-email-oritw@il.ibm.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 09/02/2009 06:38 PM, oritw@il.ibm.com wrote:
> From: Orit Wasserman<oritw@il.ibm.com>
>
> ---
>   arch/x86/kvm/vmx.c |   24 +++++++++++++++++++++++-
>   1 files changed, 23 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index abba325..2b1fc3b 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -70,6 +70,8 @@ struct vmcs {
>   struct nested_vmx {
>   	/* Has the level1 guest done vmon? */
>   	bool vmon;
> +	/* Has the level1 guest done vmclear? */
> +	bool vmclear;
>   };
>    

Doesn't seem these two belong in the same structure - vmclear is 
per-vmcs... but you're probably aware of that with the multi-guest 
support coming.


-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.