From: Tejun Heo <tj@kernel.org>
To: Greg KH <greg@kroah.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
linux-pci@vger.kernel.org, Shane Huang <Shane.Huang@amd.com>
Subject: Re: [PATCH] pci: separate out pci_add_dynid()
Date: Thu, 03 Sep 2009 07:29:58 +0900 [thread overview]
Message-ID: <4A9EF1E6.9010002@kernel.org> (raw)
In-Reply-To: <20090902133020.GA25201@kroah.com>
Hello, Greg.
Greg KH wrote:
>> +EXPORT_SYMBOL(pci_add_dynid);
>
> scripts/checkpatch.pl will complain about this :)
>
> Care to mark it EXPORT_SYMBOL_GPL() please?
Yeap, I just moved the code a bit so was a bit hesitant to add _GPL
there when all other functions didn't have it. Oh well, it's not like
external drivers would it. I'll.
> With that change, then feel free to add:
> Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
Thanks.
--
tejun
next prev parent reply other threads:[~2009-09-02 22:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-02 9:20 [PATCH] pci: separate out pci_add_dynid() Tejun Heo
2009-09-02 9:22 ` [PATCH 2/2] pci-stub: add pci_stub.ids parameter Tejun Heo
2009-09-02 13:30 ` [PATCH] pci: separate out pci_add_dynid() Greg KH
2009-09-02 22:29 ` Tejun Heo [this message]
2009-09-02 16:10 ` Grant Grundler
2009-09-02 17:56 ` Greg KH
2009-09-02 22:38 ` Tejun Heo
2009-09-02 22:43 ` Tejun Heo
2009-09-03 0:05 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A9EF1E6.9010002@kernel.org \
--to=tj@kernel.org \
--cc=Shane.Huang@amd.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.