All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Jiri Pirko <jpirko@redhat.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	Linux Netdev List <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next-2.6]  net: net/core/dev.c cleanups
Date: Thu, 03 Sep 2009 14:03:09 +0200	[thread overview]
Message-ID: <4A9FB07D.5000509@gmail.com> (raw)
In-Reply-To: <20090903115026.GD2885@psychotron.lab.eng.brq.redhat.com>

Jiri Pirko a écrit :
> Hmm, this patch causes following warnings for me:
> 
> eth%d dev=ffff88007b9dc000 queue_count=1 tx=ffff88007c565e00

Oops !

Sorry, I left a debugging aid :(

Thanks Jiri

[PATCH net-next-2.6] net: Remove debugging code

Remove a debugging aid I accidently left in previous 'cleanup' patch

Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
---
diff --git a/net/core/dev.c b/net/core/dev.c
index dd94ae6..1a6561b 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -5155,8 +5155,6 @@ struct net_device *alloc_netdev_mq(int sizeof_priv, const char *name,
 	}
 
 	dev = PTR_ALIGN(p, NETDEV_ALIGN);
-	pr_err("%s dev=%p queue_count=%d tx=%p\n", name, dev, queue_count, tx);
-	WARN_ON(queue_count == 1);
 	dev->padded = (char *)dev - (char *)p;
 
 	if (dev_addr_init(dev))

  reply	other threads:[~2009-09-03 12:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-03  8:19 [PATCH net-next-2.6] net: net/core/dev.c cleanups Eric Dumazet
2009-09-03  8:29 ` David Miller
2009-09-03 11:50 ` Jiri Pirko
2009-09-03 12:03   ` Eric Dumazet [this message]
2009-09-03 12:17     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A9FB07D.5000509@gmail.com \
    --to=eric.dumazet@gmail.com \
    --cc=davem@davemloft.net \
    --cc=jpirko@redhat.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.