All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel Glöckner" <dg@emlix.com>
To: Manuel Jander <manuel.jander@gmail.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: Patch for au88x0 driver. Fix audacious issue and add	auto reset in case of hardware ADB ctrl failure.
Date: Fri, 04 Sep 2009 11:27:51 +0200	[thread overview]
Message-ID: <4AA0DD97.6010405@emlix.com> (raw)
In-Reply-To: <21ed1c370909031310i8c899fbw919b033315e15af@mail.gmail.com>

On 09/03/2009 10:10 PM, Manuel Jander wrote:
> does anybody still have a AU88x0 card ? I know they are quite ancient
> now, but if anyone could give the attached patch a try ? Would be
> nice.

I can test an AU8820 on 2.4.37 and, if you wait >9 days, an AU8810 on a recent
kernel, but what is this hunk supposed to do?:

--- linux-2.6.30.4_orig/sound/pci/au88x0/au88x0_core.c  2009-07-31 00:34:47.0000
00000 +0200
+++ linux-2.6.30.4/sound/pci/au88x0/au88x0_core.c       2009-09-02 00:13:59.4671
19172 +0200
@@ -2800,7 +2804,7 @@
 {
 	int a, this_194;

-	if ((bits != 8) && (bits != 16))
+	if ((bits != 8) || (bits != 16))
 		return -1;

 	switch (encod) {

Any special tests you want me to do? I don't think I have encountered a "Vortex:
vortex_fifo_set*ctrl fail" message before.

  Daniel


-- 
Dipl.-Math. Daniel Glöckner, emlix GmbH, http://www.emlix.com
Fon +49 551 30664-0, Fax -11, Bahnhofsallee 1b, 37081 Göttingen, Germany
Sitz der Gesellschaft: Göttingen, Amtsgericht Göttingen HR B 3160
Geschäftsführer: Dr. Uwe Kracke, Ust-IdNr.: DE 205 198 055

emlix - your embedded linux partner

  parent reply	other threads:[~2009-09-04  9:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-03 20:10 Patch for au88x0 driver. Fix audacious issue and add auto reset in case of hardware ADB ctrl failure Manuel Jander
2009-09-04  8:49 ` Alan Horstmann
2009-09-04  9:27 ` Daniel Glöckner [this message]
2009-09-04  9:35   ` Takashi Iwai
2009-09-04 18:26   ` Manuel Jander
  -- strict thread matches above, loose matches on Subject: below --
2009-09-07  1:47 Raymond Yau
     [not found] ` <21ed1c370909070232v42f31fa9y303def4cc4002b19@mail.gmail.com>
2009-09-08  3:41   ` Raymond Yau
2009-09-01 22:31 Manuel Jander

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AA0DD97.6010405@emlix.com \
    --to=dg@emlix.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=manuel.jander@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.