From: Artem Bityutskiy <dedekind1@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: linux-omap@vger.kernel.org,
Andy Shevchenko <ext-andriy.shevchenko@nokia.com>
Subject: Re: [PATCH 3/4] dspbridge: use linux memory allocator directly
Date: Fri, 04 Sep 2009 14:02:02 +0300 [thread overview]
Message-ID: <4AA0F3AA.5070606@gmail.com> (raw)
In-Reply-To: <1252055941-29745-4-git-send-email-andy.shevchenko@gmail.com>
Nice cleanups of the cra^H^Hode now one cared about!
:-)
On 09/04/2009 12:19 PM, Andy Shevchenko wrote:
> #define LST_ELEM list_head
> @@ -85,9 +85,9 @@ struct LST_LIST {
> static inline struct LST_LIST *LST_Create(void)
> {
> struct LST_LIST *pList;
> + gfp_t flags = (in_atomic()) ? GFP_ATOMIC : GFP_KERNEL;
>
> - pList = (struct LST_LIST *) MEM_Calloc(sizeof(struct LST_LIST),
> - MEM_NONPAGED);
> + pList = kzalloc(sizeof(*pList), flags);
> if (pList != NULL)
> INIT_LIST_HEAD(&pList->head);
Would be nice to kill this whole function as well.
> @@ -116,8 +116,7 @@ static inline struct LST_LIST *LST_Create(void)
> */
> static inline void LST_Delete(struct LST_LIST *pList)
> {
> - if (pList != NULL)
> - MEM_Free(pList);
> + kfree(pList);
> }
I guess whole 'LST_Delete()' could go away as well?
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-09-04 11:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-04 9:18 dspbridge rfc: get rid of services/list.c (rebased) Andy Shevchenko
2009-09-04 9:18 ` [PATCH 1/4] DSPBRIDGE: Get rid of services/list.c Andy Shevchenko
2009-09-04 9:18 ` [PATCH 2/4] " Andy Shevchenko
2009-09-04 9:19 ` [PATCH 3/4] dspbridge: use linux memory allocator directly Andy Shevchenko
2009-09-04 9:19 ` [PATCH 4/4] dspbridge: Change LST_ELEM to list_head entirely Andy Shevchenko
2009-09-04 11:02 ` Artem Bityutskiy [this message]
2009-09-04 11:17 ` [PATCH 3/4] dspbridge: use linux memory allocator directly Andy Shevchenko
-- strict thread matches above, loose matches on Subject: below --
2009-09-03 9:06 dspbridge rfc: get rid of services/list.c (try 2) Andy Shevchenko
2009-09-03 9:06 ` [PATCH 1/4] DSPBRIDGE: Get rid of services/list.c (step 1) Andy Shevchenko
2009-09-03 9:06 ` [PATCH 2/4] DSPBRIDGE: Get rid of services/list.c (step 2) Andy Shevchenko
2009-09-03 9:06 ` [PATCH 3/4] dspbridge: use linux memory allocator directly Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AA0F3AA.5070606@gmail.com \
--to=dedekind1@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=ext-andriy.shevchenko@nokia.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.