All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/5] qdev: device capabilities
Date: Fri, 04 Sep 2009 10:08:09 -0500	[thread overview]
Message-ID: <4AA12D59.6040208@codemonkey.ws> (raw)
In-Reply-To: <1251714459-2467-1-git-send-email-kraxel@redhat.com>

Gerd Hoffmann wrote:
>   Hi,
>
> This patch series adds device capabilities to qdev devices.
>
> First patch adds the infrastructure, next patches add the capabilities.
> New member of this patch series is #5 which adds a watchdog capability
> and uses it to kill the superfluous private driver list in watchdog.c.
>
> Individual patches have more detailed descriptions.
>   

I still don't understand why this is needed.  It's duplicating data that 
should already be present in the device model.

A device has a capability because it supports a particular interface.  
Doesn't it make more sense to tie that interface to qdev instead of 
having to explicitly state the device has that interface?

Regards,

Anthony Liguori

> cheers,
>   Gerd
>
>
>
>   

  parent reply	other threads:[~2009-09-04 15:08 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-31 10:27 [Qemu-devel] [PATCH 0/5] qdev: device capabilities Gerd Hoffmann
2009-08-31 10:27 ` [Qemu-devel] [PATCH 1/5] " Gerd Hoffmann
2009-08-31 10:27 ` [Qemu-devel] [PATCH 2/5] qdev: add audio capability Gerd Hoffmann
2009-08-31 10:27 ` [Qemu-devel] [PATCH 3/5] qdev: add ethernet capability Gerd Hoffmann
2009-08-31 10:27 ` [Qemu-devel] [PATCH 4/5] qdev: add display capability Gerd Hoffmann
2009-08-31 10:27 ` [Qemu-devel] [PATCH 5/5] qdev: add watchdog capability Gerd Hoffmann
2009-09-04 15:08 ` Anthony Liguori [this message]
2009-09-04 15:16   ` [Qemu-devel] [PATCH 0/5] qdev: device capabilities Gerd Hoffmann
2009-09-05 13:39     ` Anthony Liguori
2009-09-07 10:47       ` Gerd Hoffmann
2009-09-07 20:36         ` Anthony Liguori
2009-09-08  6:52           ` Gerd Hoffmann
2009-09-10 16:30             ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AA12D59.6040208@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.