All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joerg Albert <jal2@gmx.de>
To: "Luis R. Rodriguez" <lrodriguez@atheros.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
	Christian Lamparter <chunkeey@googlemail.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 1/2] ath,ar9170: move CTL_ defines into regd.h
Date: Sat, 05 Sep 2009 22:32:44 +0200	[thread overview]
Message-ID: <4AA2CAEC.3000908@gmx.de> (raw)
In-Reply-To: <43e72e890909051233s3df12787oa1c59a8b9728c271@mail.gmail.com>

On 09/05/2009 09:33 PM, Luis R. Rodriguez wrote:
> On Sat, Sep 5, 2009 at 7:07 AM, Joerg Albert<jal2@gmx.de> wrote:
>> The ar9170 driver needs the defines for conformance test limit groups
>> and cannot include regd_common.h
>>
>> Signed-off-by: Joerg Albert <jal2@gmx.de>
> 
> Acked-by: Luis R. Rodriguez <lrodriguez@atheros.com>
> 
> Just please test compilation of ath5k and ath9k as well.

They compile fine.

Sometime we should IMHO unify the CTL_* defines in the driver below ath/.
Currently ath5k, ath9k and regd.h have separate definitions for the modes, e.g.

~/src/wireless.gits/wireless-testing/drivers/net/wireless/ath$ fgrep -r --include=*.h CTL_11A *
ath5k/eeprom.h: AR5K_CTL_11A = 0,
ath9k/eeprom.h:#define CTL_11A                 0
ath9k/eeprom.h:#define CTL_11A_EXT (CTL_11A | EXT_ADDITIVE)
regd.h:#define CTL_11A                 0

Regards,
Joerg.

  reply	other threads:[~2009-09-05 20:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-05 14:07 [PATCH 1/2] ath,ar9170: move CTL_ defines into regd.h Joerg Albert
2009-09-05 19:33 ` Luis R. Rodriguez
2009-09-05 20:32   ` Joerg Albert [this message]
2009-09-05 20:41     ` Luis R. Rodriguez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AA2CAEC.3000908@gmx.de \
    --to=jal2@gmx.de \
    --cc=chunkeey@googlemail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=lrodriguez@atheros.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.