From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] fsl_i2c: increase I2C timeout values and make them configurable
Date: Sun, 06 Sep 2009 11:09:54 +0200 [thread overview]
Message-ID: <4AA37C62.5090504@denx.de> (raw)
In-Reply-To: <1252099715-19255-1-git-send-email-timur@freescale.com>
Hello Timur,
Timur Tabi wrote:
> The value of I2C_TIMEOUT in fsl_i2c.c has several problems. First, it is
> defined as CONFIG_HZ/4, but it is used as a count of microseconds, so it makes
> no sense to derive it from a clock rate. Second, the current value (250) is
> too low for some boards, so it needs to be increased. Third, the timeout
> necessary for multiple-master arbitration is larger than the timeout for basic
> read/write operations, so we shouldn't have a single constant for both timeouts.
> Finally, it would be nice if we could override these values on a per-board
> basis.
>
> Signed-off-by: Timur Tabi <timur@freescale.com>
> ---
> drivers/i2c/fsl_i2c.c | 24 ++++++++++++++++++++----
> 1 files changed, 20 insertions(+), 4 deletions(-)
Applied to u-boot-i2c.git
Thanks for your work,
bye
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
prev parent reply other threads:[~2009-09-06 9:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-04 21:28 [U-Boot] [PATCH] fsl_i2c: increase I2C timeout values and make them configurable Timur Tabi
2009-09-04 21:59 ` Wolfgang Denk
2009-09-04 22:57 ` Peter Tyser
2009-09-06 9:09 ` Heiko Schocher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AA37C62.5090504@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.