From: Avi Kivity <avi@redhat.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH] call kvm_cpu_synchronize_state() on target vcpu
Date: Wed, 09 Sep 2009 18:41:55 +0300 [thread overview]
Message-ID: <4AA7CCC3.70701@redhat.com> (raw)
In-Reply-To: <20090909153309.GD22885@redhat.com>
On 09/09/2009 06:33 PM, Gleb Natapov wrote:
> regs_modified logic doesn't work if io thread calls
> kvm_cpu_synchronize_state() since kvm_arch_get_registers()
> returns only after vcpu thread is back to kernel. Setting
> regs_modified to 1 at this stage causes loading of wrong vcpu
> state on the next vcpu_run().
>
> -static inline void kvm_arch_get_registers(CPUState *env)
> -{
> - kvm_save_registers(env);
> - kvm_save_mpstate(env);
> -}
> -
>
Please don't drop this, it's part of upstream kvm support which we're
supported to be moving towards.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2009-09-09 15:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-09 15:33 [PATCH] call kvm_cpu_synchronize_state() on target vcpu Gleb Natapov
2009-09-09 15:41 ` Avi Kivity [this message]
2009-09-09 15:47 ` Jan Kiszka
2009-09-09 15:49 ` Gleb Natapov
2009-09-09 15:57 ` Jan Kiszka
2009-09-09 16:07 ` Gleb Natapov
2009-09-09 16:21 ` Jan Kiszka
2009-09-09 16:27 ` Gleb Natapov
2009-09-09 16:32 ` Jan Kiszka
2009-09-09 16:36 ` Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AA7CCC3.70701@redhat.com \
--to=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.