From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MlTl4-0000jS-VD for qemu-devel@nongnu.org; Wed, 09 Sep 2009 16:27:15 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MlTl0-0000bQ-9Q for qemu-devel@nongnu.org; Wed, 09 Sep 2009 16:27:14 -0400 Received: from [199.232.76.173] (port=40953 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MlTl0-0000b1-4F for qemu-devel@nongnu.org; Wed, 09 Sep 2009 16:27:10 -0400 Received: from fmmailgate03.web.de ([217.72.192.234]:43152) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MlTkz-0007F5-17 for qemu-devel@nongnu.org; Wed, 09 Sep 2009 16:27:09 -0400 Message-ID: <4AA80FA0.3090203@web.de> Date: Wed, 09 Sep 2009 22:27:12 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1252339585-27797-1-git-send-email-kraxel@redhat.com> <1252339585-27797-23-git-send-email-kraxel@redhat.com> <4AA8075E.2090102@web.de> <4AA80D99.3060604@redhat.com> In-Reply-To: <4AA80D99.3060604@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig0D751647E5FAB3886BF3122A" Sender: jan.kiszka@web.de Subject: [Qemu-devel] Re: [PATCH 22/23] monitor: fix muxing List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig0D751647E5FAB3886BF3122A Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Gerd Hoffmann wrote: > On 09/09/09 21:51, Jan Kiszka wrote: >> Gerd Hoffmann wrote: >>> make the mux driver send mux_in and mux_out events when switching >>> focus while hooking up more handlers. >>> >>> stop using CharDriverState->focus in monitor.c, track state using >>> the mux events instead. This also removes the implicit assumtion >>> that a muxed monitor allways has mux channel 0. >> >> Nice patch in the right direction, but it comes with a regression: Whe= n >> you enable the monitor on mux'ed stdio via CTRL-A C, you don't get a >> prompt until pressing some key. >=20 > Incremental fix attached. Works, perfect. >=20 >> Please add braces at this chance. >=20 > Will do. Fine. And please also reorder that "if (-1 !=3D chr->focus)" :) Jan --------------enig0D751647E5FAB3886BF3122A Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkqoD6QACgkQniDOoMHTA+mXEgCeLgQAypGtfaoZ2ZfhuN1dncG7 oAwAn3ZrqP69XZIg/mc7cG7OuYXqi89F =nAUC -----END PGP SIGNATURE----- --------------enig0D751647E5FAB3886BF3122A--