From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCHv2 1/2] mpc52xx, mucmc52, uc101: config cleanup
Date: Thu, 10 Sep 2009 14:45:05 +0200 [thread overview]
Message-ID: <4AA8F4D1.8000302@denx.de> (raw)
In-Reply-To: <m2pr9zaso8.fsf@ohwell.denx.de>
Hello Detlev,
Detlev Zundel wrote:
>> - as this boards are similiar, collect common config option
>> in manroland-common.h and manroland-mpc52xx-common.h
>> for mpc52xx specific common options for this manufacturer.
>> - add OF support
>> - update default environment
>
> Argh, sorry for interrupting again, but I think I suggested something
> problematic on second thought:
>
>> include/configs/manroland-mpc52xx-common.h | 230 ++++++++++++++++++++++++
>
> [...]
>
>> diff --git a/include/configs/manroland-mpc52xx-common.h b/include/configs/manroland-mpc52xx-common.h
>> new file mode 100644
>> index 0000000..b29ef9b
>> --- /dev/null
>> +++ b/include/configs/manroland-mpc52xx-common.h
>
> [...]
>
>> +#define CONFIG_MPC5xxx 1 /* This is an MPC5xxx CPU */
>> +#define CONFIG_MPC5200 1 /* (more precisely an MPC5200 CPU) */
>
> So all boards using manroland-mpc52xx-common.h are in fact 5200s. In
> this case, I should have suggested the filename
> "manroland-mpc5200-common.h" as the "xx" part surely cannot be anything
> else then "00".
Argh.. and I didn;t detected it too ;-)
> Sorry for this wrong lead.
No problem, I send a patch soon, if the rest of this patch is ok.
bye
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2009-09-10 12:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-09 7:14 [U-Boot] [PATCH 1/2] mpc52xx, mucmc52, uc101: config cleanup Heiko Schocher
2009-09-09 8:36 ` Wolfgang Denk
2009-09-09 11:54 ` Detlev Zundel
2009-09-09 12:05 ` Wolfgang Denk
2009-09-10 5:56 ` [U-Boot] [PATCHv2 " Heiko Schocher
2009-09-10 12:30 ` Detlev Zundel
2009-09-10 12:45 ` Heiko Schocher [this message]
2009-09-10 18:19 ` [U-Boot] [PATCHv3 1/2] mpc5200, " Heiko Schocher
2009-09-14 13:57 ` Detlev Zundel
2009-09-10 18:20 ` [U-Boot] [PATCHv3 2/2] mucmc52, uc101: delete ata@3a00 node, if no CF card is detected Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AA8F4D1.8000302@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.