All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maxim Uvarov <muvarov@ru.mvista.com>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org
Subject: Re: [MIPS] TLB  handler fix for vmalloc'ed addresses
Date: Thu, 10 Sep 2009 19:48:09 +0400	[thread overview]
Message-ID: <4AA91FB9.205@ru.mvista.com> (raw)
In-Reply-To: <20090910153744.GA10998@linux-mips.org>

>>>> }
>>> So your test case allocates vmalloc memory but never touches it.
>> Yes, it is so. Bug occurs on rmmod this module. (Module does not free memory
>> allocated with vmalloc().
> 
> Nor does it stop the thread on exit or avoid unloading.  So panicing is
> expected.

Ralf, I'm sorry for misunderstanding.  Original kernel does panic in this situation. 
In my patch it went to panic with
+		else if (pgd_page_vaddr(*pgd) != pgd_page_vaddr(*pgd_k))
+				goto no_context;

Actually it was the reason of this patch.

But looks like we need go immediately to no_context for 64 bit and do not do this checks.

Maxim.

  reply	other threads:[~2009-09-10 15:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-08 13:06 [MIPS] TLB handler fix for vmalloc'ed addresses Maxim Uvarov
2009-09-10 14:15 ` Ralf Baechle
2009-09-10 14:37   ` Maxim Uvarov
2009-09-10 15:37     ` Ralf Baechle
2009-09-10 15:48       ` Maxim Uvarov [this message]
2009-09-10 16:00         ` Maxim Uvarov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AA91FB9.205@ru.mvista.com \
    --to=muvarov@ru.mvista.com \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.