All of lore.kernel.org
 help / color / mirror / Atom feed
From: Karl Hiramoto <karl@hiramoto.org>
To: "Philip A. Prindeville" <philipp_subx@redfish-solutions.com>
Cc: netdev@vger.kernel.org, linux-atm-general@lists.sourceforge.net
Subject: Re: [Linux-ATM-General] [PATCH] atm/br2684: netif_stop_queue() when atm	device busy and netif_wake_queue() when we can send packets again.
Date: Thu, 10 Sep 2009 23:30:44 +0200	[thread overview]
Message-ID: <4AA97004.2010904@hiramoto.org> (raw)
In-Reply-To: <4AA95838.4010007@redfish-solutions.com>

Philip A. Prindeville wrote:
> I had noticed that with my Solos card, and using Qwest 7062/896kb/s
> service that I was typically only getting ~400kb/s upstream, so I
> thought that delayed transmitter restarts might be the culprit and
> decided to try out this patch.
>
> I'm running 2.6.27.26, and I modified the patch as below.
>
> Has anyone confirmed this patch (Karl's) against 2.6.27?
>
> Thanks,
>
> -Philip
I'd be interested in hearing comparisons with/without the patch.    What 
i have is no upstream packet loss with this patch, however slightly 
lower total throughput.  I think because the upper networking layers 
take time to restart the packet flow.   I'm not really sure if or how 
many packets to upper layers buffer.  I haven't had time to debug it 
further.

I don't have a solos card, but you may have to tweak the solos driver 
sk_sndbuf  value.

--
Karl

  reply	other threads:[~2009-09-10 21:30 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-28 10:38 [PATCH] br2684 testing needed for packet loss and performance Karl Hiramoto
2009-08-28 12:25 ` [Linux-ATM-General] " Chas Williams (CONTRACTOR)
2009-08-29 10:24   ` Karl Hiramoto
2009-08-29 11:24     ` [PATCH] atm/br2684: netif_stop_queue() when atm device busy and netif_wake_queue() when we can send packets again Karl Hiramoto
2009-08-31 14:29       ` Chas Williams (CONTRACTOR)
2009-09-03  6:27         ` David Miller
2009-09-03 13:44           ` Chas Williams (CONTRACTOR)
2009-09-10 19:49       ` [Linux-ATM-General] " Philip A. Prindeville
2009-09-10 21:30         ` Karl Hiramoto [this message]
2009-09-11 18:48           ` David Miller
2009-09-15 13:44             ` Karl Hiramoto
2009-09-15 14:57               ` Karl Hiramoto
2009-09-16 18:04                 ` Philip A. Prindeville
2009-09-11 19:56           ` Philip A. Prindeville

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AA97004.2010904@hiramoto.org \
    --to=karl@hiramoto.org \
    --cc=linux-atm-general@lists.sourceforge.net \
    --cc=netdev@vger.kernel.org \
    --cc=philipp_subx@redfish-solutions.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.