From: Eric Dumazet <eric.dumazet@gmail.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: netdev@vger.kernel.org
Subject: [PATCH iproute2] ss: adds a space before congestion string
Date: Fri, 11 Sep 2009 10:32:29 +0200 [thread overview]
Message-ID: <4AAA0B1D.90402@gmail.com> (raw)
In-Reply-To: <20090910120416.6fd03d1f@s6510>
Stephen Hemminger a écrit :
> I am putting together release for 2.6.31 based tools.
> The only open issue is how to deal with the error handling in commands
> that do monitoring filtering. Right now leaning towards the two socket
> solution.
>
> So if you have anything else that you have been waiting for,
> please drop me a note.
Another patch would be nice too :
ss -io
ESTAB 0 0 55.225.18.16:52668 55.225.18.187:49531
sackbic wscale:2,6 rto:219 rtt:19.75/16.5 ato:40 cwnd:4 send 2.4Mbps rcv_space:5840
Note the 'sackbic' string, instead of sack bic ?
Thanks
[PATCH] ss: adds a space before congestion string
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
---
diff --git a/misc/ss.c b/misc/ss.c
index 651fe3b..9396468 100644
--- a/misc/ss.c
+++ b/misc/ss.c
@@ -1302,7 +1302,7 @@ static void tcp_show_info(const struct nlmsghdr *nlh, struct inet_diag_msg *r)
}
if (tb[INET_DIAG_CONG])
- printf("%s", (char *) RTA_DATA(tb[INET_DIAG_CONG]));
+ printf(" %s", (char *) RTA_DATA(tb[INET_DIAG_CONG]));
if (info->tcpi_options & TCPI_OPT_WSCALE)
printf(" wscale:%d,%d", info->tcpi_snd_wscale,
next prev parent reply other threads:[~2009-09-11 8:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-10 19:04 iproute2 tools for 2.6.31 Stephen Hemminger
2009-09-11 7:48 ` Eric Dumazet
2009-09-11 7:51 ` Eric Dumazet
2009-09-11 8:32 ` Eric Dumazet [this message]
2009-09-11 15:07 ` [PATCH iproute2] ss: adds a space before congestion string Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AAA0B1D.90402@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.