All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 4/8] ide/qdev: add ide bus.
Date: Fri, 11 Sep 2009 17:01:09 +0200	[thread overview]
Message-ID: <4AAA6635.3060004@redhat.com> (raw)
In-Reply-To: <87fxatcz1s.fsf@pike.pond.sub.org>

>> +    qdev_init(dev);
>
> Callback dev->info is ide_qdev_init(), which can fail, so qdev_init()
> can fail, can't it?

Indeed, will fix.

cheers,
   Gerd

  reply	other threads:[~2009-09-11 15:01 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-11 12:32 [Qemu-devel] [PATCH 0/8] ide: convert to qdev Gerd Hoffmann
2009-09-11 12:32 ` [Qemu-devel] [PATCH 1/8] qdev/pci: add pci_create_noinit() Gerd Hoffmann
2009-09-11 14:14   ` Markus Armbruster
2009-09-11 14:28     ` Gerd Hoffmann
2009-09-11 14:57       ` Markus Armbruster
2009-09-11 12:32 ` [Qemu-devel] [PATCH 2/8] support media=cdrom for if=none Gerd Hoffmann
2009-09-11 12:32 ` [Qemu-devel] [PATCH 3/8] split away drive init from ide_init2() Gerd Hoffmann
2009-09-11 14:27   ` Markus Armbruster
2009-09-11 14:36     ` Gerd Hoffmann
2009-09-11 12:32 ` [Qemu-devel] [PATCH 4/8] ide/qdev: add ide bus Gerd Hoffmann
     [not found]   ` <m3fxat8u80.fsf@neno.mitica>
2009-09-11 14:10     ` [Qemu-devel] " Gerd Hoffmann
2009-09-11 14:54   ` [Qemu-devel] " Markus Armbruster
2009-09-11 15:01     ` Gerd Hoffmann [this message]
2009-09-11 12:32 ` [Qemu-devel] [PATCH 5/8] ide/pci: convert to qdev Gerd Hoffmann
     [not found]   ` <m3bplh8u13.fsf@neno.mitica>
2009-09-11 14:13     ` [Qemu-devel] " Gerd Hoffmann
     [not found]       ` <m3my517dni.fsf@neno.mitica>
2009-09-11 14:58         ` Gerd Hoffmann
     [not found]           ` <m3y6ol5x64.fsf@neno.mitica>
2009-09-11 19:16             ` Gerd Hoffmann
     [not found]               ` <m3bplh2js1.fsf@neno.mitica>
2009-09-14  7:09                 ` Gerd Hoffmann
2009-09-11 15:21   ` [Qemu-devel] " Markus Armbruster
2009-09-14  6:44     ` Gerd Hoffmann
2009-09-11 12:32 ` [Qemu-devel] [PATCH 6/8] ide/isa: " Gerd Hoffmann
2009-09-11 12:32 ` [Qemu-devel] [PATCH 7/8] isa: refine irq reservations Gerd Hoffmann
2009-09-11 12:32 ` [Qemu-devel] [PATCH 8/8] unbreak ppc/prep Gerd Hoffmann
2009-09-11 14:31 ` [Qemu-devel] Re: [PATCH 0/8] ide: convert to qdev Juan Quintela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AAA6635.3060004@redhat.com \
    --to=kraxel@redhat.com \
    --cc=armbru@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.