From: "Török Edwin" <edwintorok@gmail.com>
To: rostedt@goodmis.org
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>,
Li Zefan <lizf@cn.fujitsu.com>,
Mathieu Desnoyers <compudj@krystal.dyndns.org>
Subject: Re: [PATCH 3/3] tracing: add latency format to function_graph tracer
Date: Fri, 11 Sep 2009 19:08:00 +0300 [thread overview]
Message-ID: <4AAA75E0.6020604@gmail.com> (raw)
In-Reply-To: <1252684229.18996.699.camel@gandalf.stny.rr.com>
On 2009-09-11 18:50, Steven Rostedt wrote:
> On Fri, 2009-09-11 at 18:38 +0300, Török Edwin wrote:
>
>> On 2009-09-11 18:18, Frederic Weisbecker wrote:
>>
>>> On Fri, Sep 11, 2009 at 11:11:56AM -0400, Steven Rostedt wrote:
>>>
>>
>>
>>>> Ug! I just noticed that tgid was added to struct trace_entry, with the
>>>> only user as the user stack entry. This should be in the user stack
>>>> field not something that goes into every event!
>>>>
>>>> I guess I need to fix that too.
>>>>
>>>>
>> Indeed tgid should be part of struct userstack_entry, and set in
>> ftrace_trace_userstack.
>> Do you want to me to write up a patch for that, or have you already
>> fixed it?
>>
>
> I've just fixed it, thanks!
Ok.
BTW any plans on integrating an in-kernel unwinder like systemtap has?
Even if I build libc with framepointers, a userspace stacktrace on
x86-64 can't go beyond most pthreads routines, like __read_nocancel
(they're written in asm maybe?).
Best regards,
--Edwin
next prev parent reply other threads:[~2009-09-11 16:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-11 13:54 [PATCH 0/3] [GIT PULL] tracing: various updates Steven Rostedt
2009-09-11 13:54 ` [PATCH 1/3] x86/tracing: comment need for atomic nop Steven Rostedt
2009-09-11 13:54 ` [PATCH 2/3] tracing/profile: add ref count for registering profile events Steven Rostedt
2009-09-11 14:04 ` Peter Zijlstra
2009-09-11 14:09 ` Peter Zijlstra
2009-09-11 14:33 ` Steven Rostedt
2009-09-11 14:37 ` Peter Zijlstra
2009-09-11 14:52 ` Steven Rostedt
2009-09-12 14:14 ` Mathieu Desnoyers
2009-09-11 14:40 ` Steven Rostedt
2009-09-11 14:12 ` Steven Rostedt
2009-09-11 13:54 ` [PATCH 3/3] tracing: add latency format to function_graph tracer Steven Rostedt
2009-09-11 14:55 ` Frederic Weisbecker
2009-09-11 15:11 ` Steven Rostedt
2009-09-11 15:18 ` Frederic Weisbecker
2009-09-11 15:38 ` Török Edwin
2009-09-11 15:43 ` Frederic Weisbecker
2009-09-11 15:50 ` Steven Rostedt
2009-09-11 16:08 ` Török Edwin [this message]
2009-09-12 10:25 ` Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AAA75E0.6020604@gmail.com \
--to=edwintorok@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=compudj@krystal.dyndns.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.