Re: [Qemu-devel] [PATCH 09/12] cpuid: simplify CPUID flag search function

[Andre Przywara <andre.przywara@amd.com>]

Amit Shah wrote:
> On (Fri) Sep 11 2009 [00:20:54], Andre Przywara wrote:
>> avoid code duplication and handle the CPUID flag name search in a
>> loop.
>> --- a/target-i386/cpuid.c
>> +++ b/target-i386/cpuid.c
>> @@ -71,29 +71,22 @@ static void add_flagname_to_bitmaps(const char *flagname, uint32_t *features,
>>                                      uint32_t *ext2_features,
>>                                      uint32_t *ext3_features)
>>  {
 >>...
>> +    for (j = 0; j < 4; j++) {
>> +        for (i = 0; i < 32; i++) {
>> +            if (feature_names[j][i] &&
>> +                !strcmp(flagname, feature_names[j][i])) {
>> +                *feature_flags[j] |= 1 << i;
>> +                found = 1;
>> +            }
>> +    }
>>      if (!found) {
>>          fprintf(stderr, "CPU feature %s not found\n", flagname);
>>      }
> 
> This just reports the entire string, right? Not just the feature as the
> printf suggests.
What makes you think so? flagname is just the single flag (being 
returned by strtok in the caller, wich null-terminates its results). 
Otherwise the strcmp() above would not work either...
Unknown flags will be reported, but do not abort QEMU (I checked this 
myself by accident ;-)

Regards,
Andre.

-- 
Andre Przywara
AMD-OSRC (Dresden)
Tel: x29712