From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MmnLN-0005hU-0O for qemu-devel@nongnu.org; Sun, 13 Sep 2009 07:34:09 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MmnLI-0005gS-2Y for qemu-devel@nongnu.org; Sun, 13 Sep 2009 07:34:08 -0400 Received: from [199.232.76.173] (port=35946 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MmnLH-0005gP-S5 for qemu-devel@nongnu.org; Sun, 13 Sep 2009 07:34:03 -0400 Received: from fmmailgate03.web.de ([217.72.192.234]:48737) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MmnLH-0007Ui-4x for qemu-devel@nongnu.org; Sun, 13 Sep 2009 07:34:03 -0400 Message-ID: <4AACD8A9.8090201@web.de> Date: Sun, 13 Sep 2009 13:34:01 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <20090913081951.GO22885@redhat.com> In-Reply-To: <20090913081951.GO22885@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigA17A2D1EE45A56478046F0DE" Sender: jan.kiszka@web.de Subject: [Qemu-devel] Re: [PATCH] set correct CS seg limit and flags on sipi List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gleb Natapov Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigA17A2D1EE45A56478046F0DE Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Gleb Natapov wrote: > TCG works with incorrect values somehow. TCG doesn't care about limits and has only few segment type checks. Some link to the corresponding spec section would be nice-to-have in this commit message. I was looking for a reference what registers SIPIs actually modify and how, but there seems to be none, at least in the System Programming Guide. >=20 > Signed-off-by: Gleb Natapov > diff --git a/hw/apic.c b/hw/apic.c > index 2c414c1..c89008e 100644 > --- a/hw/apic.c > +++ b/hw/apic.c > @@ -516,7 +516,7 @@ void apic_sipi(CPUState *env) > =20 > env->eip =3D 0; > cpu_x86_load_seg_cache(env, R_CS, s->sipi_vector << 8, s->sipi_vec= tor << 12, > - 0xffff, 0); > + env->segs[R_CS].limit, env->segs[R_CS].flag= s); > env->halted =3D 0; > s->wait_for_sipi =3D 0; > } > -- > Gleb. Jan --------------enigA17A2D1EE45A56478046F0DE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkqs2KkACgkQniDOoMHTA+nc6gCfQi/ZcEnoSoShVAi2LFqjD/85 rt0Ani9h/0YRqg7hb62ZkPjy6zuYnYeu =x84n -----END PGP SIGNATURE----- --------------enigA17A2D1EE45A56478046F0DE--