From: Uri Okrent <uokrent@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>,
Owen Taylor <otaylor@redhat.com>,
git@vger.kernel.org, Colin Walters <walters@verbum.org>
Subject: Re: git push --confirm ?
Date: Sun, 13 Sep 2009 09:59:01 -0700 [thread overview]
Message-ID: <4AAD24D5.1010504@gmail.com> (raw)
In-Reply-To: <20090913105247.GA21750@coredump.intra.peff.net>
Jeff King wrote:
[snip]
> Besides being a lot more annoying to implement, there is one big
> downside: in many cases the single TCP connection is a _feature_. If you
> are pushing via ssh and providing a password manually, it is a
> significant usability regression to have to input it twice.
>
> Also, given that ssh is going to be by far the biggest transport for
> pushing via the git protocol, I suspect any timeouts are set for
> _before_ the authentication phase (i.e., SSH times you out if you don't
> actually log in). So in that sense it may not be worth worrying about
> how long we take during the push itself.
That doesn't seem like a huge hurdle to overcome. Most ssh clients support some
sort of ServerAliveInterval parameter for just this reason. Sending a keep alive
packet every 60 seconds or so while waiting for user confirmation doesn't seem
all that egregious.
--
Uri
Please consider the environment before printing this message.
http://www.panda.org/how_you_can_help/
prev parent reply other threads:[~2009-09-13 16:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-12 17:51 git push --confirm ? Owen Taylor
2009-09-12 18:43 ` Jeff King
2009-09-12 20:11 ` Owen Taylor
2009-09-12 20:49 ` Jeff King
2009-09-12 21:55 ` Daniel Barkalow
2009-09-13 0:41 ` Junio C Hamano
2009-09-13 9:33 ` Jeff King
2009-09-13 10:37 ` Junio C Hamano
2009-09-13 10:52 ` Jeff King
2009-09-13 16:59 ` Uri Okrent [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AAD24D5.1010504@gmail.com \
--to=uokrent@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=otaylor@redhat.com \
--cc=peff@peff.net \
--cc=walters@verbum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.