Re: [PATCH 1/5] SCSI: Add support for 32-byte CDBs

[Boaz Harrosh <bharrosh@panasas.com>]

On 09/15/2009 10:29 AM, Martin K. Petersen wrote:
>>>>>> "Boaz" == Boaz Harrosh <bharrosh@panasas.com> writes:
> 
> Boaz> This patch replaces both:
> Boaz> 	[PATCH 1/5] SCSI: Add support for 32-byte CDBs
> Boaz>   [PATCH 4/5] sd: Support disks formatted with DIF Type 2
> 
> Boaz> right?
> 
> Yep.
> 
> 
> Boaz> One question below
> 
>>> + SCpnt->cmnd = mempool_alloc(sd_cdb_pool, GFP_ATOMIC);
>>> +
> 
> Boaz> The cmd_len gets updated later on, in scsi_lib.c right?
> 
> Nope.  But you are right that I should set cmd_len correctly.  Otherwise
> LLDs won't transfer sufficient CDB data (that's obviously not a problem
> for scsi_debug which is what I've been using for testing).
> 

It does in scsi_init_cmd_errh() which is called from scsi_request_fn().
It does:
	if (cmd->cmd_len == 0)
		cmd->cmd_len = scsi_command_size(cmd->cmnd);

Now scsi_command_size() perfectly understand VARIABLE_LENGTH_CMD, but it might
be clearer to set it here next to the command setup, in sd.c.

Boaz