From: ANNIE LI <annie.li@oracle.com>
To: Keir Fraser <keir.fraser@eu.citrix.com>
Cc: Joshua West <jwest@brandeis.edu>,
Dan Magenheimer <dan.magenheimer@oracle.com>,
xen-devel <xen-devel@lists.xensource.com>,
"Kurt C. Hackel" <kurt.hackel@oracle.com>,
James Harper <james.harper@bendigoit.com.au>,
"wayne.gong@oracle.com" <wayne.gong@oracle.com>
Subject: Re: Error restoring DomU when using GPLPV
Date: Wed, 16 Sep 2009 12:37:32 +0800 [thread overview]
Message-ID: <4AB06B8C.6010403@oracle.com> (raw)
In-Reply-To: <C6D5C5E1.14CE2%keir.fraser@eu.citrix.com>
Hi,
> Actually of course you do the right thing with the shinfo page, so actually
> one page per migration does get switched back to being a Xenheap page (the
> shinfo page) and tot_pages actually increases by 3 on the first migration,
> then decreases by 1 when shinfo gets remapped by the PV drivers. Then
> increases by 1 on every future migration (which is the shinfo Xenheap page
> getting changed into a domheap page), and then decreases by 1 when shinfo
> gets remapped by the PV drivers.
>
> But even setting things out exactly right as above, the end result is the
> same: I *still* cannot explain Annie's result.
The root cause is that winpv driver did not re-map gnttab frames during
resuming.
Thanks Mukesh very much.
My initial implementation was to map all 32 grant table pages during
initialization, and then balloon down
those pages during driver first load. However, i leaked those 32 grant
pages if i did not re-map those pages
during resuming. This is why Save/restore can work only once.
My second implementation is to map corresponding grant frames device
needs instead of all 32 grant table.
But it will leak 2 frames every migration because of missing re-mapping
grant tables.
Then i tried to re-map the grant table during resuming, and balloon down
shinfo+gntab driver first load.
I did save/restore several times, did not hit any problem. Furthermore,
i also tried to map 64 grant table pages
during initialization and ballooned down those pages, all work fine.
I will do more test to make sure it and update here.
Thanks
Annie.
next prev parent reply other threads:[~2009-09-16 4:37 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-04 1:22 Error restoring DomU when using GPLPV James Harper
2009-08-04 1:41 ` James Harper
2009-08-04 5:30 ` James Harper
2009-08-04 6:10 ` James Harper
2009-08-04 7:58 ` James Harper
2009-08-04 8:21 ` Keir Fraser
2009-08-04 9:01 ` James Harper
2009-08-04 9:27 ` Keir Fraser
2009-08-04 9:34 ` James Harper
2009-08-04 10:28 ` Keir Fraser
2009-08-04 10:40 ` James Harper
2009-08-04 11:02 ` Keir Fraser
2009-08-04 11:34 ` James Harper
2009-08-04 13:12 ` Keir Fraser
2009-08-18 8:17 ` Pasi Kärkkäinen
2009-08-18 9:33 ` James Harper
2009-08-19 7:39 ` ANNIE LI
2009-08-19 7:52 ` Keir Fraser
2009-08-20 3:21 ` ANNIE LI
2009-09-05 4:02 ` Mukesh Rathor
2009-09-05 6:49 ` Keir Fraser
2009-08-20 8:17 ` ANNIE LI
2009-08-20 8:27 ` Keir Fraser
2009-08-20 9:42 ` James Harper
2009-08-20 10:05 ` ANNIE LI
2009-08-20 10:20 ` Keir Fraser
2009-08-20 11:55 ` ANNIE LI
2009-08-20 12:28 ` Keir Fraser
2009-08-21 4:11 ` ANNIE LI
2009-08-26 11:04 ` ANNIE LI
2009-08-27 9:28 ` ANNIE LI
2009-08-28 3:10 ` ANNIE LI
2009-09-02 4:05 ` ANNIE LI
2009-09-02 4:27 ` ANNIE LI
2009-09-04 21:28 ` Dan Magenheimer
2009-09-04 23:02 ` Dan Magenheimer
2009-09-05 6:52 ` Keir Fraser
2009-09-05 7:33 ` ANNIE LI
2009-09-15 2:25 ` Mukesh Rathor
2009-09-15 7:39 ` Keir Fraser
2009-09-15 19:14 ` Mukesh Rathor
2009-09-15 21:25 ` Keir Fraser
2009-09-15 21:29 ` Keir Fraser
2009-09-15 22:27 ` Mukesh Rathor
2009-09-16 4:37 ` ANNIE LI [this message]
2009-09-16 11:10 ` ANNIE LI
2009-09-16 12:28 ` Keir Fraser
2009-09-16 18:09 ` Dan Magenheimer
2009-09-16 20:50 ` Mukesh Rathor
2009-09-17 6:21 ` Keir Fraser
2009-09-17 15:41 ` Dan Magenheimer
2009-09-24 20:24 ` Error restoring DomU when using GPLPV / fix for GPLPV drivers Pasi Kärkkäinen
2009-10-27 20:05 ` Keith Coleman
2009-08-20 10:19 ` Error restoring DomU when using GPLPV Keir Fraser
2009-08-20 10:41 ` Keir Fraser
2009-08-04 10:39 ` James Harper
2009-08-04 9:26 ` James Harper
2009-08-25 10:02 ` Wayne Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AB06B8C.6010403@oracle.com \
--to=annie.li@oracle.com \
--cc=dan.magenheimer@oracle.com \
--cc=james.harper@bendigoit.com.au \
--cc=jwest@brandeis.edu \
--cc=keir.fraser@eu.citrix.com \
--cc=kurt.hackel@oracle.com \
--cc=wayne.gong@oracle.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.