diff for duplicates of <4AB0B8F4.50301@grandegger.com> diff --git a/a/1.txt b/N1/1.txt index 58366cd..5e474b1 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,7 +1,7 @@ Marc Kleine-Budde wrote: > This patch add the driver for the SoC CAN controller in Atmel's AT91SAM9263. > -> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de> +> Signed-off-by: Marc Kleine-Budde <mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> I already reviewed at91_can.c on the Socket-CAN ML and it's almost OK from the Socket-CAN point of view. I just realized two minor issues: @@ -53,14 +53,14 @@ It should depend on CAN_DEV because it used the CAN device driver interface. > +/* > + * at91_can.c - CAN network driver for AT91 SoC CAN controller > + * -> + * (C) 2007 by Hans J. Koch <hjk@linutronix.de> -> + * (C) 2008, 2009 by Marc Kleine-Budde <kernel@pengutronix.de> +> + * (C) 2007 by Hans J. Koch <hjk-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org> +> + * (C) 2008, 2009 by Marc Kleine-Budde <kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> > + * > + * This software may be distributed under the terms of the GNU General > + * Public License ("GPL") version 2 as distributed in the 'COPYING' > + * file from the main directory of the linux kernel source. > + * -> + * Send feedback to <socketcan-users@lists.berlios.de> +> + * Send feedback to <socketcan-users-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org> This driver uses platform data. Could you please add some description on how they should be used, e.g. like for the MCP251x: diff --git a/a/content_digest b/N1/content_digest index f775fef..be9712b 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,16 +2,20 @@ "ref\01253094405-3216-2-git-send-email-mkl@pengutronix.de\0" "ref\01253094405-3216-3-git-send-email-mkl@pengutronix.de\0" "ref\01253094405-3216-4-git-send-email-mkl@pengutronix.de\0" - "From\0wg@grandegger.com (Wolfgang Grandegger)\0" - "Subject\0[PATCH 3/3] at91_can: add driver for Atmel's CAN controller on AT91SAM9263\0" + "ref\01253094405-3216-4-git-send-email-mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org\0" + "From\0Wolfgang Grandegger <wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>\0" + "Subject\0Re: [PATCH 3/3] at91_can: add driver for Atmel's CAN controller on AT91SAM9263\0" "Date\0Wed, 16 Sep 2009 12:07:48 +0200\0" - "To\0linux-arm-kernel@lists.infradead.org\0" + "To\0Marc Kleine-Budde <mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>\0" + "Cc\0Socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org" + netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org + " linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org\0" "\00:1\0" "b\0" "Marc Kleine-Budde wrote:\n" "> This patch add the driver for the SoC CAN controller in Atmel's AT91SAM9263.\n" "> \n" - "> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>\n" + "> Signed-off-by: Marc Kleine-Budde <mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>\n" "\n" "I already reviewed at91_can.c on the Socket-CAN ML and it's almost OK\n" "from the Socket-CAN point of view. I just realized two minor issues:\n" @@ -63,14 +67,14 @@ "> +/*\n" "> + * at91_can.c - CAN network driver for AT91 SoC CAN controller\n" "> + *\n" - "> + * (C) 2007 by Hans J. Koch <hjk@linutronix.de>\n" - "> + * (C) 2008, 2009 by Marc Kleine-Budde <kernel@pengutronix.de>\n" + "> + * (C) 2007 by Hans J. Koch <hjk-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>\n" + "> + * (C) 2008, 2009 by Marc Kleine-Budde <kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>\n" "> + *\n" "> + * This software may be distributed under the terms of the GNU General\n" "> + * Public License (\"GPL\") version 2 as distributed in the 'COPYING'\n" "> + * file from the main directory of the linux kernel source.\n" "> + *\n" - "> + * Send feedback to <socketcan-users@lists.berlios.de>\n" + "> + * Send feedback to <socketcan-users-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org>\n" "\n" "This driver uses platform data. Could you please add some description on\n" "how they should be used, e.g. like for the MCP251x:\n" @@ -102,4 +106,4 @@ "\n" Wolfgang. -70b10207db9174fe880502e9d40e7d2f36ba45b73dc347c10bd2150f93e57d41 +3e9650882f96bf6c8ad16d5ce25e144a7b48f3abbdc188f447bf7f2806aa8bfb
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.