[Qemu-devel] Re: [PATCH 1/2] qemu/qdev: type safety in reset handler

[Gerd Hoffmann <kraxel@redhat.com>]

On 09/15/09 23:37, Michael S. Tsirkin wrote:
> On Tue, Sep 15, 2009 at 11:16:42PM +0200, Paolo Bonzini wrote:
>>
>> He means not introducing pci_rtl8139_reset.
>>
>> Paolo
>
> Several places in this file use the variant that gets RTL8139State,
> to me it seems nicer to have that in a single place.

How about creating a helper macro to go from ${device}State to 
DeviceState, then kill the wrapper function?  i.e something like this:

#define TO_QDEV_STATE(state) (&((state)->dev.qdev))

Then have one reset function which accepts DeviceState.  The call sites 
which have RTL8139State at hand can use rtl8139_reset(TO_QDEV_STATE(s));

cheers,
   Gerd