All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Jeff Garzik <jeff@garzik.org>,
	IDE/ATA development list <linux-ide@vger.kernel.org>
Subject: Commit 54c38444fad6a99b4b19512f8f0055d69115e69e
Date: Wed, 16 Sep 2009 20:56:08 +0900	[thread overview]
Message-ID: <4AB0D258.60503@kernel.org> (raw)

Jeff,

Commit 54c38444fad6a99b4b19512f8f0055d69115e69e triggers
WARN_ON_ONCE(ap->pflags & ATA_PFLAG_FROZEN); in ata_qc_complete().
>From the commit history, it seems the change was to add DMA engine
disable to sil_freeze(), right?  I can't see why changing the orders
would matter there.  ata_port_abort() just changes the internal state
of libata and doesn't affect low level driver or the hardware.
Whether doing it before or after __ata_port_freeze() shouldn't make
any different to sata_sil's freeze callback.  Am I missing something?

Thanks.

-- 
tejun

             reply	other threads:[~2009-09-16 11:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-16 11:56 Tejun Heo [this message]
2009-09-17  7:11 ` Commit 54c38444fad6a99b4b19512f8f0055d69115e69e Jeff Garzik
2009-09-17  7:30   ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AB0D258.60503@kernel.org \
    --to=tj@kernel.org \
    --cc=jeff@garzik.org \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.