From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mnuv4-0008Ai-RH for qemu-devel@nongnu.org; Wed, 16 Sep 2009 09:51:38 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mnuuz-00088P-5v for qemu-devel@nongnu.org; Wed, 16 Sep 2009 09:51:38 -0400 Received: from [199.232.76.173] (port=49577 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mnuuz-00088M-1j for qemu-devel@nongnu.org; Wed, 16 Sep 2009 09:51:33 -0400 Received: from mail-yx0-f201.google.com ([209.85.210.201]:36949) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mnuuy-0008Fe-ND for qemu-devel@nongnu.org; Wed, 16 Sep 2009 09:51:32 -0400 Received: by yxe39 with SMTP id 39so6265683yxe.18 for ; Wed, 16 Sep 2009 06:51:31 -0700 (PDT) Message-ID: <4AB0ED60.9000706@codemonkey.ws> Date: Wed, 16 Sep 2009 08:51:28 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: optional feature References: <20090916104620.GA4456@redhat.com> <20090916111845.GJ23157@redhat.com> <20090916115726.GL23157@redhat.com> In-Reply-To: <20090916115726.GL23157@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gleb Natapov Cc: "Michael S. Tsirkin" , qemu-devel@nongnu.org, Juan Quintela Gleb Natapov wrote: > I don't know virtio enough to understand all those things below. I am > asking what is wrong about how RTC did it? You don't need if's or > whiles. You have general RTC sate in one table and things that needed by > rtc-td-hack in another table. The only awkward bit is that we want to connect the savevm state to a qdev device. Ideally, each qdev device would have a single table of state. > From vmstate point of view those are not > connected. Serialization/deserialization should support matching of > incomming binary blob to deserialize function. With vmstate, we're moving away from the notion of blobs and serialization functions. Instead, for a given qdev device, vmstate describes it's state in a table. Regards, Anthony Liguori