Re: [PATCH 2/2] policAycoreutils: share setfiles restore function with restorecond

[Joshua Brindle <method@manicmethod.com>]

[-- Attachment #1: Type: text/plain, Size: 1841 bytes --]



Daniel J Walsh wrote:
> On 08/20/2009 10:15 AM, Joshua Brindle wrote:
>    
>> Daniel J Walsh wrote:
>>      
>>> On 08/19/2009 05:01 PM, Joshua Brindle wrote:
>>>        
>>>> Thomas Liu wrote:
>>>>          
>>>>> This patch edits restorecond to use the shared restore
>>>>>
>>>>> functions split out from the first patch in this series.
>>>>>
>>>>>            
>>>> Is the DBus stuff in here suppose to be here? It looks like you are
>>>> adding libdbus and include dirs but I don't see any dbus usage.
>>>>
>>>>          
>> <snip>
>>      
>>> restorcond -u is a dbus session bus service.
>>>
>>> The idea is to run restorecond as your UID when you log into a console
>>> session.
>>>
>>>        
>> Maybe I don't get how DBus works. Why are the include dirs added to
>> CFLAGS but no apparent dbus #includes?
>>
>> Further, will this _only_ work with DBus after this patch? If so there
>> needs to be a way to not build it if dbus isn't present on the system
>> (embedded).
>>
>> -- 
>> This message was distributed to subscribers of the selinux mailing list.
>> If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov
>> with
>> the words "unsubscribe selinux" without quotes as the message.
>>
>>
>>      
> Ok here is another patch with all of the dbus stuff aggregated under a HAVE_DBUS flag.
>
> You can build it with or without DBUS support and it should work fine.
>
> DBUS is really used to make sure multiple restorecond do not get started.
>    

This patch got badly broken by a few recent commits, which is totally my 
fault for not applying it earlier. I'll try to rebase it but my main 
objection is that restorecond is now using object files from setfiles. I 
know they are in the same 'package' but they are separate apps. Maybe we 
should move restore.{c,h} to policycoreutils/common or something.


[-- Attachment #2: Type: text/html, Size: 2565 bytes --]