From: Oren Laadan <orenl-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org>
To: Nathan Lynch <ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
Cc: containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org
Subject: Re: [PATCH 3/9] futex.h: fix compat builds
Date: Wed, 16 Sep 2009 11:36:16 -0400 [thread overview]
Message-ID: <4AB105F0.4040105@librato.com> (raw)
In-Reply-To: <1253091418-14807-4-git-send-email-ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
Nathan Lynch wrote:
> With any build where CONFIG_COMPAT=y:
>
> checkpoint/process.c: In function 'save_task_robust_futex_list':
> checkpoint/process.c:37: error: implicit declaration of function 'ptr_to_compat'
> checkpoint/process.c:38: error: dereferencing pointer to incomplete type
> checkpoint/process.c: In function 'restore_task_robust_futex_list':
> checkpoint/process.c:54: error: implicit declaration of function 'compat_ptr'
> checkpoint/process.c:54: warning: assignment makes pointer from integer without a cast
> checkpoint/process.c:55: error: implicit declaration of function 'do_compat_set_robust_list'
>
> ptr_to_compat et al need compat.h; however, futex.h is exported while
> compat.h is not. So the include is guarded by #ifdef __KERNEL__.
>
> Signed-off-by: Nathan Lynch <ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
Including futex.h does not require compat.h. Rather, it's the code
in checkpoint/process.c that uses ptr_to_compat() et al. Is there a
reason not to include compat.h from checkpoint/process.c instead ?
Oren.
next prev parent reply other threads:[~2009-09-16 15:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-16 8:56 [PATCH 0/9] powerpc checkpoint/restart kernel support Nathan Lynch
[not found] ` <1253091418-14807-1-git-send-email-ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
2009-09-16 8:56 ` [PATCH 1/9] checkpoint: fix integer-pointer conversion warnings Nathan Lynch
[not found] ` <1253091418-14807-2-git-send-email-ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
2009-09-16 14:21 ` Serge E. Hallyn
[not found] ` <20090916142137.GA13476-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-09-16 15:08 ` Oren Laadan
[not found] ` <4AB0FF6E.6010505-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org>
2009-09-16 17:03 ` Serge E. Hallyn
2009-09-16 8:56 ` [PATCH 2/9] fix trivial build breaks in compat code Nathan Lynch
2009-09-16 8:56 ` [PATCH 3/9] futex.h: fix compat builds Nathan Lynch
[not found] ` <1253091418-14807-4-git-send-email-ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
2009-09-16 15:36 ` Oren Laadan [this message]
[not found] ` <4AB105F0.4040105-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org>
2009-09-16 17:46 ` Nathan Lynch
2009-09-16 8:56 ` [PATCH 4/9] powerpc: reserve checkpoint arch identifiers Nathan Lynch
2009-09-16 8:56 ` [PATCH 5/9] powerpc: provide APIs for validating and updating DABR Nathan Lynch
2009-09-16 8:56 ` [PATCH 6/9] powerpc: checkpoint/restart implementation Nathan Lynch
2009-09-16 8:56 ` [PATCH 7/9] powerpc: wire up checkpoint and restart syscalls Nathan Lynch
2009-09-16 8:56 ` [PATCH 8/9] powerpc: enable checkpoint support in Kconfig Nathan Lynch
2009-09-16 8:56 ` [PATCH 9/9] powerpc: clone_with_pids implementation Nathan Lynch
2009-09-16 15:11 ` [PATCH 0/9] powerpc checkpoint/restart kernel support Oren Laadan
[not found] ` <4AB10008.8040401-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org>
2009-09-16 17:49 ` Nathan Lynch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AB105F0.4040105@librato.com \
--to=orenl-rdfvbdnroixbdgjk7y7tuq@public.gmane.org \
--cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
--cc=ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.