From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from msux-gh1-uea02.nsa.gov (msux-gh1-uea02.nsa.gov [63.239.67.2]) by tarius.tycho.ncsc.mil (8.13.1/8.13.1) with ESMTP id n8GH8FLv016592 for ; Wed, 16 Sep 2009 13:08:15 -0400 Received: from mx1.redhat.com (localhost [127.0.0.1]) by msux-gh1-uea02.nsa.gov (8.12.10/8.12.10) with ESMTP id n8GH9cjq025006 for ; Wed, 16 Sep 2009 17:09:39 GMT Message-ID: <4AB11B7C.3070000@redhat.com> Date: Wed, 16 Sep 2009 13:08:12 -0400 From: Daniel J Walsh MIME-Version: 1.0 To: Joshua Brindle CC: selinux@tycho.nsa.gov Subject: Re: [PATCH 2/2] policAycoreutils: share setfiles restore function with restorecond References: <1250711251.2835.25.camel@Hephaestus> <4A8C683F.8070005@manicmethod.com> <4A8C6F26.6080304@redhat.com> <4A8D5A8F.8060306@manicmethod.com> <4A8D8BBD.80600@redhat.com> <4AB0FA6A.7010206@manicmethod.com> In-Reply-To: <4AB0FA6A.7010206@manicmethod.com> Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-selinux@tycho.nsa.gov List-Id: selinux@tycho.nsa.gov On 09/16/2009 10:47 AM, Joshua Brindle wrote: > > > Daniel J Walsh wrote: >> On 08/20/2009 10:15 AM, Joshua Brindle wrote: >> >>> Daniel J Walsh wrote: >>> >>>> On 08/19/2009 05:01 PM, Joshua Brindle wrote: >>>> >>>>> Thomas Liu wrote: >>>>> >>>>>> This patch edits restorecond to use the shared restore >>>>>> >>>>>> functions split out from the first patch in this series. >>>>>> >>>>>> >>>>> Is the DBus stuff in here suppose to be here? It looks like you are >>>>> adding libdbus and include dirs but I don't see any dbus usage. >>>>> >>>>> >>> >>> >>>> restorcond -u is a dbus session bus service. >>>> >>>> The idea is to run restorecond as your UID when you log into a console >>>> session. >>>> >>>> >>> Maybe I don't get how DBus works. Why are the include dirs added to >>> CFLAGS but no apparent dbus #includes? >>> >>> Further, will this _only_ work with DBus after this patch? If so there >>> needs to be a way to not build it if dbus isn't present on the system >>> (embedded). >>> >>> -- >>> This message was distributed to subscribers of the selinux mailing list. >>> If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov >>> with >>> the words "unsubscribe selinux" without quotes as the message. >>> >>> >>> >> Ok here is another patch with all of the dbus stuff aggregated under a >> HAVE_DBUS flag. >> >> You can build it with or without DBUS support and it should work fine. >> >> DBUS is really used to make sure multiple restorecond do not get started. >> > > This patch got badly broken by a few recent commits, which is totally my > fault for not applying it earlier. I'll try to rebase it but my main > objection is that restorecond is now using object files from setfiles. I > know they are in the same 'package' but they are separate apps. Maybe we > should move restore.{c,h} to policycoreutils/common or something. > > I have no problem doing this, although I question it's usefullness since restore.[ch] Is the only one, now if we were to move restore.[ch] to libselinux... -- This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with the words "unsubscribe selinux" without quotes as the message.